From: Pavel Machek <pavel@ucw.cz>
To: Brian Norris <computersforpeace@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org, Len Brown <len.brown@intel.com>,
Chirantan Ekbote <chirantan@chromium.org>
Subject: Re: [PATCH] PM / sleep: add configurable delay for pm_test
Date: Wed, 17 Dec 2014 10:22:55 +0100 [thread overview]
Message-ID: <20141217092255.GA4588@amd> (raw)
In-Reply-To: <20141217091057.GH7112@brian-ubuntu>
> > Make it module parameter so that the patch is two lines of code. If
> > that does not work for you, think of something that does.
>
> OK, so that's actually constructive. If lines of code is really the most
> important factor here, then I suppose I can do that. I'd argue that a
> module parameter is a much less sensible interface here, though, given
> that it is coupled with the existing /sys/power/pm_test interface.
If module parameter works for you, we have a winner, that should be
two lines of code and two lines of documentation.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-12-17 9:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 23:55 [PATCH] PM / sleep: add configurable delay for pm_test Brian Norris
[not found] ` <20140904071412.GA29832@amd>
2014-09-04 17:54 ` Brian Norris
2014-09-05 2:11 ` Chirantan Ekbote
2014-12-13 2:55 ` Brian Norris
2014-12-13 8:31 ` Pavel Machek
2014-12-16 23:58 ` Brian Norris
2014-12-17 8:09 ` Pavel Machek
2014-12-17 9:10 ` Brian Norris
2014-12-17 9:22 ` Pavel Machek [this message]
2015-02-21 20:25 ` Florian Fainelli
2015-02-21 20:32 ` Pavel Machek
2015-02-21 22:56 ` Florian Fainelli
2015-02-21 23:24 ` Pavel Machek
2015-02-22 8:23 ` Brian Norris
2015-02-22 8:26 ` [PATCH v2] " Brian Norris
2015-02-22 12:27 ` Pavel Machek
2015-02-22 15:17 ` Kevin Cernekee
2015-02-22 19:25 ` Florian Fainelli
2015-02-23 5:16 ` [PATCH v3] " Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141217092255.GA4588@amd \
--to=pavel@ucw.cz \
--cc=chirantan@chromium.org \
--cc=computersforpeace@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).