From: Pavel Machek <pavel@ucw.cz>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: 이종화 <jonghwa3.lee@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"sre@kernel.org" <sre@kernel.org>,
"dbaryshkov@gmail.com" <dbaryshkov@gmail.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"anton@enomsg.org" <anton@enomsg.org>,
최찬우 <cw00.choi@samsung.com>
Subject: Re: [PATCH RESEND v2 03/10] power: charger-manager: Remove deprecated function, cm_notify_event().
Date: Sat, 20 Dec 2014 01:16:22 +0100 [thread overview]
Message-ID: <20141220001622.GA1694@amd> (raw)
In-Reply-To: <1255984171.39711418975524329.JavaMail.weblogic@epmlwas08d>
On Fri 2014-12-19 07:52:07, MyungJoo Ham wrote:
> >
> > cm_notify_event() is introduced to get event associated with battery status
> > externally, but no one had been used. Moreover it makes charger manager
> > driver more complicated. This patch tries to drop the function and all data
> > related to simplify the driver.
> >
> > Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
>
> You are not just removing cm_notify_event() and its related.
>
> You are hereby removing the much of software charger control
> and suspend-related operations. Could you please be more specific
> on why? (many of such features are to comply with operators' requirements)
>
> (Or we may meet next Monday for some discussions :) )
So... you'll meet in person and we will not see fireworks on the
mailing list? :-).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-12-20 0:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 7:52 [PATCH RESEND v2 03/10] power: charger-manager: Remove deprecated function, cm_notify_event() MyungJoo Ham
2014-12-19 8:32 ` jonghwa3.lee
2014-12-20 0:16 ` Pavel Machek [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-19 2:47 [PATCH RESEND V2 0/10] Improve charger manager driver for optimized operation Jonghwa Lee
2014-12-19 2:47 ` [PATCH RESEND v2 03/10] power: charger-manager: Remove deprecated function, cm_notify_event() Jonghwa Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141220001622.GA1694@amd \
--to=pavel@ucw.cz \
--cc=anton@enomsg.org \
--cc=cw00.choi@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jonghwa3.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).