From: Eduardo Valentin <edubezval@gmail.com>
To: Javi Merino <javi.merino@arm.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
Kapileshwar Singh <Kapileshwar.Singh@arm.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Punit Agrawal <Punit.Agrawal@arm.com>
Subject: Re: Fix: Bind Cooling Device Weight
Date: Mon, 5 Jan 2015 17:24:58 -0400 [thread overview]
Message-ID: <20150105212456.GA31536@developer> (raw)
In-Reply-To: <20141229104021.GD32102@e104805>
[-- Attachment #1: Type: text/plain, Size: 775 bytes --]
On Mon, Dec 29, 2014 at 10:40:21AM +0000, Javi Merino wrote:
<cut>
>
> The patch "thermal: let governors have private data for each thermal
> zone" that you applied[0] allows you to do that. Governors
> can have a bind_to_tz() op that can fail. If it does, then the switch
> doesn't happen and you continue with the old governor.
>
> [0] http://article.gmane.org/gmane.linux.power-management.general/54163
>
Agreed.
Rui, the naming '.bind_to_tz()' seams to be appropriated here, even
considering the validation perspective you mentioned. Binding to a
thermal zone should be the best opportunity to check if the zone makes sense
for that governor. Don't you agree?
I think the .bind_to_tz() should be enough for both cases.
> Cheers,
> Javi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-01-05 21:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 12:19 Fix: Bind Cooling Device Weight Kapileshwar Singh
2014-12-18 13:43 ` Eduardo Valentin
2014-12-18 16:44 ` Kapileshwar Singh
2014-12-22 3:23 ` Zhang Rui
2014-12-22 16:36 ` Kapileshwar Singh
2015-01-05 21:31 ` Eduardo Valentin
2015-01-06 16:38 ` Kapileshwar Singh
2015-01-06 18:37 ` Eduardo Valentin
2015-01-07 14:08 ` Kapileshwar Singh
2014-12-22 3:18 ` Zhang Rui
2014-12-29 10:40 ` Javi Merino
2015-01-05 21:24 ` Eduardo Valentin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150105212456.GA31536@developer \
--to=edubezval@gmail.com \
--cc=Kapileshwar.Singh@arm.com \
--cc=Punit.Agrawal@arm.com \
--cc=javi.merino@arm.com \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).