Re: [PATCH 2/2] thermal: rcar: change type of ctemp in rcar_thermal_update_temp()

[Eduardo Valentin <edubezval@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]

Shimoda-san,

On Tue, Jan 06, 2015 at 07:02:08PM +0900, Yoshihiro Shimoda wrote:
> Since the ctemp is used for rcar_thermal_write() in
> rcar_thermal_update_temp(), the type of ctemp should be "u32" instead
> of "int".

In your V2, can you please include in your description that you are also
updating the helper variables 'old' and 'new'?

The description does not mention it.

> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
>  drivers/thermal/rcar_thermal.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
> index bbdf64e..6dcead1 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -63,7 +63,7 @@ struct rcar_thermal_priv {
>  	struct mutex lock;
>  	struct list_head list;
>  	int id;
> -	int ctemp;
> +	u32 ctemp;
>  };
>  
>  #define rcar_thermal_for_each_priv(pos, common)	\
> @@ -145,7 +145,7 @@ static int rcar_thermal_update_temp(struct rcar_thermal_priv *priv)
>  {
>  	struct device *dev = rcar_priv_to_dev(priv);
>  	int i;
> -	int ctemp, old, new;
> +	u32 ctemp, old, new;

But you also update them, as necessary.

>  	int ret = -EINVAL;
>  
>  	mutex_lock(&priv->lock);
> -- 
> 1.7.9.5
> 


BR, 

Eduardo Valentin

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]