linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Valentin <edubezval@gmail.com>
To: Anson Huang <b20788@freescale.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	rui.zhang@intel.com, jangra.pankaj9@gmail.com
Subject: Re: [PATCH V2] Thermal: imx: add clk disable/enable for suspend/resume
Date: Tue, 6 Jan 2015 09:25:48 -0400	[thread overview]
Message-ID: <20150106132546.GB16132@developer> (raw)
In-Reply-To: <1420541422-27602-1-git-send-email-b20788@freescale.com>

[-- Attachment #1: Type: text/plain, Size: 1484 bytes --]

On Tue, Jan 06, 2015 at 06:50:22PM +0800, Anson Huang wrote:
> Thermal sensor's clk is from pll3_usb_otg, per hardware
> design requirement, need to make sure pll3_usb_otg is disabled
> before STOP mode is entered, otherwise, all PFDs under it may
> enter incorrect state, this patch disables pll3_usb_otg before
> suspend and enables it after resume.
> 
> Signed-off-by: Anson Huang <b20788@freescale.com>

adding to my -fixes branch.

> ---
>  drivers/thermal/imx_thermal.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
> index 461bf3d..dc8bcd8 100644
> --- a/drivers/thermal/imx_thermal.c
> +++ b/drivers/thermal/imx_thermal.c
> @@ -600,6 +600,7 @@ static int imx_thermal_suspend(struct device *dev)
>  	regmap_write(map, TEMPSENSE0 + REG_CLR, TEMPSENSE0_MEASURE_TEMP);
>  	regmap_write(map, TEMPSENSE0 + REG_SET, TEMPSENSE0_POWER_DOWN);
>  	data->mode = THERMAL_DEVICE_DISABLED;
> +	clk_disable_unprepare(data->thermal_clk);
>  
>  	return 0;
>  }
> @@ -609,6 +610,7 @@ static int imx_thermal_resume(struct device *dev)
>  	struct imx_thermal_data *data = dev_get_drvdata(dev);
>  	struct regmap *map = data->tempmon;
>  
> +	clk_prepare_enable(data->thermal_clk);
>  	/* Enabled thermal sensor after resume */
>  	regmap_write(map, TEMPSENSE0 + REG_CLR, TEMPSENSE0_POWER_DOWN);
>  	regmap_write(map, TEMPSENSE0 + REG_SET, TEMPSENSE0_MEASURE_TEMP);
> -- 
> 1.9.1
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

      reply	other threads:[~2015-01-06 13:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-06 10:50 [PATCH V2] Thermal: imx: add clk disable/enable for suspend/resume Anson Huang
2015-01-06 13:25 ` Eduardo Valentin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150106132546.GB16132@developer \
    --to=edubezval@gmail.com \
    --cc=b20788@freescale.com \
    --cc=jangra.pankaj9@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).