* [PATCH] kernel: power: snapshot: Remove unused function
@ 2015-01-11 22:27 Rickard Strandqvist
2015-01-12 8:09 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Rickard Strandqvist @ 2015-01-11 22:27 UTC (permalink / raw)
To: Rafael J. Wysocki, Pavel Machek
Cc: Rickard Strandqvist, Len Brown, linux-pm, linux-kernel
Remove the function get_safe_write_buffer() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
kernel/power/snapshot.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
index 791a618..dac8919 100644
--- a/kernel/power/snapshot.c
+++ b/kernel/power/snapshot.c
@@ -2309,8 +2309,6 @@ static inline void free_highmem_data(void)
free_image_page(buffer, PG_UNSAFE_CLEAR);
}
#else
-static inline int get_safe_write_buffer(void) { return 0; }
-
static unsigned int
count_highmem_image_pages(struct memory_bitmap *bm) { return 0; }
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] kernel: power: snapshot: Remove unused function
2015-01-11 22:27 [PATCH] kernel: power: snapshot: Remove unused function Rickard Strandqvist
@ 2015-01-12 8:09 ` Pavel Machek
2015-01-30 0:19 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2015-01-12 8:09 UTC (permalink / raw)
To: Rickard Strandqvist; +Cc: Rafael J. Wysocki, Len Brown, linux-pm, linux-kernel
On Sun 2015-01-11 23:27:38, Rickard Strandqvist wrote:
> Remove the function get_safe_write_buffer() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: Pavel Machek <pavel@ucw.cz>
Rafael should take this, I guess...
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kernel: power: snapshot: Remove unused function
2015-01-12 8:09 ` Pavel Machek
@ 2015-01-30 0:19 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2015-01-30 0:19 UTC (permalink / raw)
To: Pavel Machek; +Cc: Rickard Strandqvist, Len Brown, linux-pm, linux-kernel
On Monday, January 12, 2015 09:09:10 AM Pavel Machek wrote:
> On Sun 2015-01-11 23:27:38, Rickard Strandqvist wrote:
> > Remove the function get_safe_write_buffer() that is not used anywhere.
> >
> > This was partially found by using a static code analysis program called cppcheck.
> >
> > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
>
> Rafael should take this, I guess...
Queued up for 3.20, thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-29 23:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-11 22:27 [PATCH] kernel: power: snapshot: Remove unused function Rickard Strandqvist
2015-01-12 8:09 ` Pavel Machek
2015-01-30 0:19 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).