linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [vireshk:cpufreq/core/locking 57/60] drivers/cpufreq/cpufreq.c:512:5: sparse: symbol '__cpufreq_boost_supported' was not declared. Should it be static?
@ 2015-01-16  6:55 kbuild test robot
  2015-01-16  6:55 ` [PATCH vireshk] cpufreq: __cpufreq_boost_supported() can be static kbuild test robot
  2015-01-16  7:05 ` [vireshk:cpufreq/core/locking 57/60] drivers/cpufreq/cpufreq.c:512:5: sparse: symbol '__cpufreq_boost_supported' was not declared. Should it be static? Viresh Kumar
  0 siblings, 2 replies; 3+ messages in thread
From: kbuild test robot @ 2015-01-16  6:55 UTC (permalink / raw)
  To: Viresh Kumar; +Cc: kbuild-all, Rafael J. Wysocki, linux-pm, linux-kernel

tree:   https://git.linaro.org/people/vireshk/linux cpufreq/core/locking
head:   12d5339e685739289c2f629c943b8bfad4c64f1e
commit: fbce49b78afdaeeaee3017cfbd968e44ddba8496 [57/60] cpufreq: Drop forward declaration of __cpufreq_boost_trigger_state()
reproduce:
  # apt-get install sparse
  git checkout fbce49b78afdaeeaee3017cfbd968e44ddba8496
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/cpufreq/cpufreq.c:512:5: sparse: symbol '__cpufreq_boost_supported' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH vireshk] cpufreq: __cpufreq_boost_supported() can be static
  2015-01-16  6:55 [vireshk:cpufreq/core/locking 57/60] drivers/cpufreq/cpufreq.c:512:5: sparse: symbol '__cpufreq_boost_supported' was not declared. Should it be static? kbuild test robot
@ 2015-01-16  6:55 ` kbuild test robot
  2015-01-16  7:05 ` [vireshk:cpufreq/core/locking 57/60] drivers/cpufreq/cpufreq.c:512:5: sparse: symbol '__cpufreq_boost_supported' was not declared. Should it be static? Viresh Kumar
  1 sibling, 0 replies; 3+ messages in thread
From: kbuild test robot @ 2015-01-16  6:55 UTC (permalink / raw)
  To: Viresh Kumar; +Cc: kbuild-all, Rafael J. Wysocki, linux-pm, linux-kernel

drivers/cpufreq/cpufreq.c:512:5: sparse: symbol '__cpufreq_boost_supported' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 cpufreq.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index c151f4b..4e3d42f 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -509,7 +509,7 @@ unlock:
 	return ret;
 }
 
-int __cpufreq_boost_supported(void)
+static int __cpufreq_boost_supported(void)
 {
 	if (likely(cpufreq_driver))
 		return cpufreq_driver->boost_supported;

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [vireshk:cpufreq/core/locking 57/60] drivers/cpufreq/cpufreq.c:512:5: sparse: symbol '__cpufreq_boost_supported' was not declared. Should it be static?
  2015-01-16  6:55 [vireshk:cpufreq/core/locking 57/60] drivers/cpufreq/cpufreq.c:512:5: sparse: symbol '__cpufreq_boost_supported' was not declared. Should it be static? kbuild test robot
  2015-01-16  6:55 ` [PATCH vireshk] cpufreq: __cpufreq_boost_supported() can be static kbuild test robot
@ 2015-01-16  7:05 ` Viresh Kumar
  1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2015-01-16  7:05 UTC (permalink / raw)
  To: kbuild test robot
  Cc: kbuild-all, Rafael J. Wysocki, linux-pm@vger.kernel.org,
	Linux Kernel Mailing List

On 16 January 2015 at 12:25, kbuild test robot <fengguang.wu@intel.com> wrote:
> tree:   https://git.linaro.org/people/vireshk/linux cpufreq/core/locking
> head:   12d5339e685739289c2f629c943b8bfad4c64f1e
> commit: fbce49b78afdaeeaee3017cfbd968e44ddba8496 [57/60] cpufreq: Drop forward declaration of __cpufreq_boost_trigger_state()
> reproduce:
>   # apt-get install sparse
>   git checkout fbce49b78afdaeeaee3017cfbd968e44ddba8496
>   make ARCH=x86_64 allmodconfig
>   make C=1 CF=-D__CHECK_ENDIAN__
>
>
> sparse warnings: (new ones prefixed by >>)
>
>>> drivers/cpufreq/cpufreq.c:512:5: sparse: symbol '__cpufreq_boost_supported' was not declared. Should it be static?
>
> Please review and possibly fold the followup patch.

Fixed. Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-01-16  7:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-16  6:55 [vireshk:cpufreq/core/locking 57/60] drivers/cpufreq/cpufreq.c:512:5: sparse: symbol '__cpufreq_boost_supported' was not declared. Should it be static? kbuild test robot
2015-01-16  6:55 ` [PATCH vireshk] cpufreq: __cpufreq_boost_supported() can be static kbuild test robot
2015-01-16  7:05 ` [vireshk:cpufreq/core/locking 57/60] drivers/cpufreq/cpufreq.c:512:5: sparse: symbol '__cpufreq_boost_supported' was not declared. Should it be static? Viresh Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).