Re: [PATCH v6 08/18] cpufreq: exynos: Use device tree to determine if cpufreq cooling should be registered

Eduardo Valentin
2015-01-25T16:46:28Z

[-- Attachment #1: Type: text/plain, Size: 1954 bytes --]

On Sun, Jan 25, 2015 at 07:31:14PM +0530, Viresh Kumar wrote:
> On 23 January 2015 at 19:27, Lukasz Majewski <l.majewski@samsung.com> wrote:
> > Please pay a note about following problem:
> >
> > Previously we got: cpu0: cpu@0 for all Exynos devices.
> >
> > Now, however, cpu numbering has changed (due to GIC rework).
> > For example:
> >
> > Exynos4412:
> > cpus {
> > cpu0: cpu@A00 {
> > ...
> > #cooling-cells = <2>; /* min followed by max */
> > };
> >
> > cpu@A01 {
> > };
> >
> > cpu@A02 {
> > };
> >
> > cpu@A03 {
> > };
> > }
> >
> > Exynos 4210:
> > cpus {
> > cpu0: cpu@900 {
> > #cooling-cells = <2>; /* min followed by max */
> > };
> >
> > cpu@901 {
> > };
> > };
> >
> > Exynos 5250:
> > cpus {
> > cpu0: cpu@0 {
> > #cooling-cells = <2>; /* min followed by max */
> > };
> >
> > cpu@1 {
> > };
> > };
> >
> >
> > As you can see different cpu@XXY nodes we have and simply calling cpu@0
> > won't work.
>
> I wasn't asked you to get the cpu0 node from dt but this:
>
> cpu_dev = get_cpu_dev(0);
> np = of_node_get(cpu_dev->of_node);
>
> Wouldn't this work? You only need to guarantee that the cooling-cells is added
> onto the boot CPUs node.

Lukasz,

I agree with Viresh here, you can simplify your code.

I, somehow, missed this conversation and already applied v6 of this
patch in my -fixes branch. Can you please fix this by sending a
differential patch on top of this one applying Viresh's commit?

Viresh, my bad, I missed your comments.

Thanks

Eduardo

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]