Re: [PATCH v3 00/16] thermal: exynos: Thermal code rework to use device tree

Tobias Jakobi
2015-01-19T23:30:08Z

Hello!

Lukasz Majewski wrote:
> We all know that this code is floating around - early version of this
> work was posted in the Q3 2013.
>
> To be fair - this code is both needed and welcome, but new problems
> with it are found (please search for recent comment from Kevin
> Hilman).
>
> From my side, I focus on the code which is in Eduardo Valentin's next
> (3.19-rc3), since I don't know when and if eventually cpufreq rework
> would be merged.
I'm sorry, my wording wasn't the best here. I'm not critizing the work
done here, merely voicing my concern (and also interest!) about how the
new stuff interacts with code that may eventually get merged.
You're aware of it, that's enough for me to know.

> The code which touches exynos-cpufreq.c is around 30 LOC, only for
> preserving cpu cooling functionality.
>
> Is it worth to wait for code developed for so long to happily apply 30
> LOC and delay removal of around 400 LOC in other subsystem (thermal)?
No, of course not. That was pretty stupid of me :(

> I rise my hand as a volunteer to fix any thermal related issues which
> show up after cpufreq rework code applying to Exynos.
That's certainly good to hear!

> This series is NOT providing any NEW functionality. It in fact
> preserves functionality, which allows using CPU frequency as a mean to
> cool the device.
I've got a question concerning this. Is this only needed for
exynos-cpufreq, or does cpufreq-dt also need something like that.

The point is that I'm still working with a rather old version of the
cpufreq series, a version which still had the Exynos4x12 code in it
(this was removed later, if I remember correctly because of problems
with how to properly describe boost configuration in DT).

Anyway, to not get completly off-topic here, I noticed some small issue
with v3 of the thermal series. I've enabled CONFIG_THERMAL_HWMON so that
I can use lm_sensors to query temperature of the board. However while
the thermal_zone is created, there is no hwmon node to be found. This
was working properly without the thermal series.

With best wishes,
Tobias