From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [RFC PATCHv2 18/19] mfd: ab8500: Decrement the power supply's device reference counter Date: Tue, 20 Jan 2015 13:36:34 +0000 Message-ID: <20150120133634.GH13701@x1> References: <1420472882-10463-1-git-send-email-k.kozlowski@samsung.com> <1420472882-10463-19-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ig0-f174.google.com ([209.85.213.174]:58565 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752500AbbATNgl (ORCPT ); Tue, 20 Jan 2015 08:36:41 -0500 Received: by mail-ig0-f174.google.com with SMTP id b16so10297154igk.1 for ; Tue, 20 Jan 2015 05:36:41 -0800 (PST) Content-Disposition: inline In-Reply-To: <1420472882-10463-19-git-send-email-k.kozlowski@samsung.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Krzysztof Kozlowski Cc: "Rafael J. Wysocki" , Len Brown , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Pavel Machek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org On Mon, 05 Jan 2015, Krzysztof Kozlowski wrote: > Use power_supply_put() to decrement the power supply's device referen= ce > counter. >=20 > Signed-off-by: Krzysztof Kozlowski > Acked-by: Pavel Machek > Acked-by: Linus Walleij > Acked-by: Lee Jones You've sent this to me already Acked. I don't see 00/00, so I have no idea what's going on. Do you want me to take this patch? Can it be taking on its own? > --- > drivers/mfd/ab8500-sysctrl.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/mfd/ab8500-sysctrl.c b/drivers/mfd/ab8500-sysctr= l.c > index d4a4b24be7c6..0d1825696153 100644 > --- a/drivers/mfd/ab8500-sysctrl.c > +++ b/drivers/mfd/ab8500-sysctrl.c > @@ -51,6 +51,7 @@ static void ab8500_power_off(void) > =20 > ret =3D power_supply_get_property(psy, POWER_SUPPLY_PROP_ONLINE, > &val); > + power_supply_put(psy); > =20 > if (!ret && val.intval) { > charger_present =3D true; > @@ -73,6 +74,7 @@ static void ab8500_power_off(void) > pss[i]); > machine_restart("charging"); > } > + power_supply_put(psy); > } > =20 > shutdown: --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog