From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCH v3 00/16] thermal: exynos: Thermal code rework to use device tree Date: Wed, 21 Jan 2015 05:08:04 -0400 Message-ID: <20150121090802.GC13468@developer.hsd1.ca.comcast.net> References: <1412872737-624-1-git-send-email-l.majewski@samsung.com> <1421242874-3425-1-git-send-email-l.majewski@samsung.com> <54B8549F.60707@gmx.net> <20150116092946.38860303@amdc2363> <54BD9377.30606@gmx.net> <20150120091729.3d01a0cf@amdc2363> <54C04D02.90405@gmx.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ctP54qlpMx3WjD+/" Return-path: Content-Disposition: inline In-Reply-To: <54C04D02.90405@gmx.net> Sender: linux-samsung-soc-owner@vger.kernel.org To: Tobias Jakobi Cc: Lukasz Majewski , Zhang Rui , Kukjin Kim , Kukjin Kim , Linux PM list , "linux-samsung-soc@vger.kernel.org" , Bartlomiej Zolnierkiewicz , Lukasz Majewski , Amit Daniel Kachhap , Abhilash Kesavan , Kyungmin Park , Chanwoo Choi , Thomas Abraham , tomasz.figa@gmail.com List-Id: linux-pm@vger.kernel.org --ctP54qlpMx3WjD+/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 22, 2015 at 02:06:10AM +0100, Tobias Jakobi wrote: > Hello! >=20 >=20 > Lukasz Majewski wrote: > >> The point is that I'm still working with a rather old version of the > >> cpufreq series, a version which still had the Exynos4x12 code in it > >> (this was removed later, if I remember correctly because of problems > >> with how to properly describe boost configuration in DT). > >=20 > > Is your board Odroid-U3/Trats2 ? > It's an Odroid-X2, so pretty similar to the U3, except that it doesn't > have any active cooling device. >=20 >=20 > >> Anyway, to not get completly off-topic here, I noticed some small > >> issue with v3 of the thermal series. I've enabled > >> CONFIG_THERMAL_HWMON so that I can use lm_sensors to query > >> temperature of the board. However while the thermal_zone is created, > >> there is no hwmon node to be found.=20 > >=20 > > I'm not surprised, that some use cases (about which I wasn't even > > aware) show up.=20 > > I've already fixed issues reported by Abhilash (with v5 and a following > > patch) and look closer into the THERMAL_HWMON. > The problem seems to be that of_parse_thermal_zones always sets > 'no_hwmon' to true, so that thermal_zone_device_register never registers > a hwmon device when the underlaying thermal zone is setup through DT. I > don't understand the rationale behind this, even with the comment ('No > hwmon because there might be hwmon drivers registering'). >=20 The reason is that hwmon sensor device drivers also register via of-thermal. So, adding hwmon interface by default will create a cyclic problem. Cheers, >=20 > > I've also done some work regarding FAN controlled by hwmon for Odroid > > U3. > > Could you look on following series: > > http://www.spinics.net/lists/linux-samsung-soc/msg40471.html > >=20 > > I can only guess that your board might need similar entries for your > > DTS file(s). >=20 > Like I said, the X2 only has a passive heatsink, so no fan controlling he= re. >=20 >=20 > With best wishes, > Tobias >=20 --ctP54qlpMx3WjD+/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUv2xpAAoJEMLUO4d9pOJWaxMH/21jWehzxIzAVttHU5WnoKOM r8DRa5M7TRpJkZ+oaO57AniVIqpO6FKdREJ6HKuk6yFhezm+TwknfdWGRn8MCNxU 5y88/3H+7+xu+ryre9N0S4qdHoumGXwrWGZ9KsOCUB9jaxfG9liHrMw/sqIbAJAM RuW46/AwfdQ06HjDwweskdTBjwlEjCVbAGqtqOPHp3+SzTzae0acB6mwLY+nf8a0 1BeonMKI8ugO90KccE/NKkdM8VP/17WXm2lISr1qCSSB52RDI8FGsXy4MsC6oSVd 0OuVqWDAFVqdiNeRRXRwEviVlhz6zX68xDyNEcTqSvUDWYJDf/t8yrgldsNwVvQ= =zl+l -----END PGP SIGNATURE----- --ctP54qlpMx3WjD+/--