* [PATCH] power: max77693: fix platform_no_drv_owner.cocci warnings
[not found] <201501211232.F4NwbEWo%fengguang.wu@intel.com>
@ 2015-01-21 4:11 ` kbuild test robot
2015-01-21 7:58 ` Krzysztof Kozlowski
2015-01-21 13:05 ` Sebastian Reichel
2015-01-21 4:11 ` [PATCH] power: max77693: fix simple_return.cocci warnings kbuild test robot
1 sibling, 2 replies; 6+ messages in thread
From: kbuild test robot @ 2015-01-21 4:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: kbuild-all, Sebastian Reichel, Dmitry Eremin-Solenikov,
David Woodhouse, linux-pm, linux-kernel
drivers/power/max77693_charger.c:747:3-8: No need to set .owner here. The core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
max77693_charger.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/power/max77693_charger.c
+++ b/drivers/power/max77693_charger.c
@@ -744,7 +744,6 @@ MODULE_DEVICE_TABLE(platform, max77693_c
static struct platform_driver max77693_charger_driver = {
.driver = {
- .owner = THIS_MODULE,
.name = "max77693-charger",
},
.probe = max77693_charger_probe,
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] power: max77693: fix simple_return.cocci warnings
[not found] <201501211232.F4NwbEWo%fengguang.wu@intel.com>
2015-01-21 4:11 ` [PATCH] power: max77693: fix platform_no_drv_owner.cocci warnings kbuild test robot
@ 2015-01-21 4:11 ` kbuild test robot
2015-01-21 7:59 ` Krzysztof Kozlowski
2015-01-21 13:05 ` Sebastian Reichel
1 sibling, 2 replies; 6+ messages in thread
From: kbuild test robot @ 2015-01-21 4:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: kbuild-all, Sebastian Reichel, Dmitry Eremin-Solenikov,
David Woodhouse, linux-pm, linux-kernel
drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be simpified
Simplify a trivial if-return sequence. Possibly combine with a
preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci
CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
max77693_charger.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
--- a/drivers/power/max77693_charger.c
+++ b/drivers/power/max77693_charger.c
@@ -612,12 +612,8 @@ static int max77693_reg_init(struct max7
if (ret)
return ret;
- ret = max77693_set_charge_input_threshold_volt(chg,
+ return max77693_set_charge_input_threshold_volt(chg,
chg->charge_input_threshold_volt);
- if (ret)
- return ret;
-
- return 0;
}
#ifdef CONFIG_OF
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] power: max77693: fix platform_no_drv_owner.cocci warnings
2015-01-21 4:11 ` [PATCH] power: max77693: fix platform_no_drv_owner.cocci warnings kbuild test robot
@ 2015-01-21 7:58 ` Krzysztof Kozlowski
2015-01-21 13:05 ` Sebastian Reichel
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-01-21 7:58 UTC (permalink / raw)
To: kbuild test robot
Cc: kbuild-all, Sebastian Reichel, Dmitry Eremin-Solenikov,
David Woodhouse, linux-pm, linux-kernel
On śro, 2015-01-21 at 12:11 +0800, kbuild test robot wrote:
> drivers/power/max77693_charger.c:747:3-8: No need to set .owner here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>
> max77693_charger.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> --- a/drivers/power/max77693_charger.c
> +++ b/drivers/power/max77693_charger.c
> @@ -744,7 +744,6 @@ MODULE_DEVICE_TABLE(platform, max77693_c
>
> static struct platform_driver max77693_charger_driver = {
> .driver = {
> - .owner = THIS_MODULE,
> .name = "max77693-charger",
> },
> .probe = max77693_charger_probe,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] power: max77693: fix simple_return.cocci warnings
2015-01-21 4:11 ` [PATCH] power: max77693: fix simple_return.cocci warnings kbuild test robot
@ 2015-01-21 7:59 ` Krzysztof Kozlowski
2015-01-21 13:05 ` Sebastian Reichel
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-01-21 7:59 UTC (permalink / raw)
To: kbuild test robot
Cc: kbuild-all, Sebastian Reichel, Dmitry Eremin-Solenikov,
David Woodhouse, linux-pm, linux-kernel
On śro, 2015-01-21 at 12:11 +0800, kbuild test robot wrote:
> drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be simpified
>
> Simplify a trivial if-return sequence. Possibly combine with a
> preceding function call.
> Generated by: scripts/coccinelle/misc/simple_return.cocci
>
> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>
> max77693_charger.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> --- a/drivers/power/max77693_charger.c
> +++ b/drivers/power/max77693_charger.c
> @@ -612,12 +612,8 @@ static int max77693_reg_init(struct max7
> if (ret)
> return ret;
>
> - ret = max77693_set_charge_input_threshold_volt(chg,
> + return max77693_set_charge_input_threshold_volt(chg,
> chg->charge_input_threshold_volt);
> - if (ret)
> - return ret;
> -
> - return 0;
> }
>
> #ifdef CONFIG_OF
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] power: max77693: fix simple_return.cocci warnings
2015-01-21 4:11 ` [PATCH] power: max77693: fix simple_return.cocci warnings kbuild test robot
2015-01-21 7:59 ` Krzysztof Kozlowski
@ 2015-01-21 13:05 ` Sebastian Reichel
1 sibling, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2015-01-21 13:05 UTC (permalink / raw)
To: kbuild test robot
Cc: Krzysztof Kozlowski, kbuild-all, Dmitry Eremin-Solenikov,
David Woodhouse, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 388 bytes --]
Hi,
On Wed, Jan 21, 2015 at 12:11:34PM +0800, kbuild test robot wrote:
> drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be simpified
>
> Simplify a trivial if-return sequence. Possibly combine with a
> preceding function call.
> Generated by: scripts/coccinelle/misc/simple_return.cocci
Thanks, applied with Reviewed-By from Krzysztof.
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] power: max77693: fix platform_no_drv_owner.cocci warnings
2015-01-21 4:11 ` [PATCH] power: max77693: fix platform_no_drv_owner.cocci warnings kbuild test robot
2015-01-21 7:58 ` Krzysztof Kozlowski
@ 2015-01-21 13:05 ` Sebastian Reichel
1 sibling, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2015-01-21 13:05 UTC (permalink / raw)
To: kbuild test robot
Cc: Krzysztof Kozlowski, kbuild-all, Dmitry Eremin-Solenikov,
David Woodhouse, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 495 bytes --]
Hi,
On Wed, Jan 21, 2015 at 12:11:34PM +0800, kbuild test robot wrote:
> drivers/power/max77693_charger.c:747:3-8: No need to set .owner here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Thanks, applied with Reviewed-By from Krzysztof.
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-01-21 13:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201501211232.F4NwbEWo%fengguang.wu@intel.com>
2015-01-21 4:11 ` [PATCH] power: max77693: fix platform_no_drv_owner.cocci warnings kbuild test robot
2015-01-21 7:58 ` Krzysztof Kozlowski
2015-01-21 13:05 ` Sebastian Reichel
2015-01-21 4:11 ` [PATCH] power: max77693: fix simple_return.cocci warnings kbuild test robot
2015-01-21 7:59 ` Krzysztof Kozlowski
2015-01-21 13:05 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).