Re: [PATCH] power: bq24190_charger: suppress build warning

[Sebastian Reichel <sre@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2047 bytes --]

Hi,

On Thu, Dec 04, 2014 at 02:56:04PM +0000, Lad, Prabhakar wrote:
> This patch fixes following build warning:
> 
> In file included from include/linux/printk.h:261:0,
>                  from include/linux/kernel.h:13,
>                  from include/linux/list.h:8,
>                  from include/linux/module.h:9,
>                  from drivers/power/bq24190_charger.c:11:
> drivers/power/bq24190_charger.c: In function ‘bq24190_irq_handler_thread’:
> include/linux/dynamic_debug.h:86:20: warning: ‘ss_reg’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>    __dynamic_dev_dbg(&descriptor, dev, fmt, \
>                     ^
> drivers/power/bq24190_charger.c:1211:5: note: ‘ss_reg’ was declared here
>   u8 ss_reg, f_reg;
>      ^
> In file included from include/linux/printk.h:261:0,
>                  from include/linux/kernel.h:13,
>                  from include/linux/list.h:8,
>                  from include/linux/module.h:9,
>                  from drivers/power/bq24190_charger.c:11:
> include/linux/dynamic_debug.h:86:20: warning: ‘f_reg’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>    __dynamic_dev_dbg(&descriptor, dev, fmt, \
>                     ^
> drivers/power/bq24190_charger.c:1211:13: note: ‘f_reg’ was declared here
>   u8 ss_reg, f_reg;
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> ---
>  drivers/power/bq24190_charger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/bq24190_charger.c b/drivers/power/bq24190_charger.c
> index ad3ff8f..72e552d 100644
> --- a/drivers/power/bq24190_charger.c
> +++ b/drivers/power/bq24190_charger.c
> @@ -1208,7 +1208,7 @@ static irqreturn_t bq24190_irq_handler_thread(int irq, void *data)
>  {
>  	struct bq24190_dev_info *bdi = data;
>  	bool alert_userspace = false;
> -	u8 ss_reg, f_reg;
> +	u8 ss_reg = 0, f_reg = 0;
>  	int ret;
>  
>  	pm_runtime_get_sync(bdi->dev);

Thanks, applied.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]