linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] thermal: Kconfig: Remove config for not used EXYNOS_THERMAL_CORE
@ 2015-01-27 11:13 Lukasz Majewski
  2015-01-27 14:55 ` Eduardo Valentin
  0 siblings, 1 reply; 3+ messages in thread
From: Lukasz Majewski @ 2015-01-27 11:13 UTC (permalink / raw)
  To: Eduardo Valentin, Paul Bolle
  Cc: Zhang Rui, Linux PM list, linux-samsung-soc@vger.kernel.org,
	Bartlomiej Zolnierkiewicz, Lukasz Majewski, Kukjin Kim,
	Amit Daniel Kachhap, Abhilash Kesavan, Abhilash Kesavan,
	Kukjin Kim, Chanwoo Choi, Lukasz Majewski

After removing exynos_thermal_common.[c|h] files the CONFIG_EXYNOS_THERMA_CORE
is not needed anymore.
This patch removes this entry from Kconfig.

Reported-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
---
 drivers/thermal/samsung/Kconfig | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
index c43306e..c8e35c1 100644
--- a/drivers/thermal/samsung/Kconfig
+++ b/drivers/thermal/samsung/Kconfig
@@ -7,12 +7,3 @@ config EXYNOS_THERMAL
 	  the TMU, reports temperature and handles cooling action if defined.
 	  This driver uses the Exynos core thermal APIs and TMU configuration
 	  data from the supported SoCs.
-
-config EXYNOS_THERMAL_CORE
-	bool "Core thermal framework support for EXYNOS SOCs"
-	depends on EXYNOS_THERMAL
-	help
-	  If you say yes here you get support for EXYNOS TMU
-	  (Thermal Management Unit) common registration/unregistration
-	  functions to the core thermal layer and also to use the generic
-	  CPU cooling APIs.
-- 
2.0.0.rc2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] thermal: Kconfig: Remove config for not used EXYNOS_THERMAL_CORE
  2015-01-27 11:13 [PATCH] thermal: Kconfig: Remove config for not used EXYNOS_THERMAL_CORE Lukasz Majewski
@ 2015-01-27 14:55 ` Eduardo Valentin
  2015-01-27 15:00   ` Lukasz Majewski
  0 siblings, 1 reply; 3+ messages in thread
From: Eduardo Valentin @ 2015-01-27 14:55 UTC (permalink / raw)
  To: Lukasz Majewski
  Cc: Paul Bolle, Zhang Rui, Linux PM list,
	linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz,
	Lukasz Majewski, Kukjin Kim, Amit Daniel Kachhap,
	Abhilash Kesavan, Abhilash Kesavan, Kukjin Kim, Chanwoo Choi

[-- Attachment #1: Type: text/plain, Size: 1526 bytes --]

On Tue, Jan 27, 2015 at 12:13:59PM +0100, Lukasz Majewski wrote:
> After removing exynos_thermal_common.[c|h] files the CONFIG_EXYNOS_THERMA_CORE
> is not needed anymore.
> This patch removes this entry from Kconfig.
> 
> Reported-by: Paul Bolle <pebolle@tiscali.nl>
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>

This patch looks fine to me and I am about to queue it in my fixes tree.
However, you must carry along another patch to remove this entry:
arch/arm/configs/exynos_defconfig:CONFIG_EXYNOS_THERMAL_CORE=y

Can you please post it and ask Kim to queue the above suggested removal
too?

> ---
>  drivers/thermal/samsung/Kconfig | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
> index c43306e..c8e35c1 100644
> --- a/drivers/thermal/samsung/Kconfig
> +++ b/drivers/thermal/samsung/Kconfig
> @@ -7,12 +7,3 @@ config EXYNOS_THERMAL
>  	  the TMU, reports temperature and handles cooling action if defined.
>  	  This driver uses the Exynos core thermal APIs and TMU configuration
>  	  data from the supported SoCs.
> -
> -config EXYNOS_THERMAL_CORE
> -	bool "Core thermal framework support for EXYNOS SOCs"
> -	depends on EXYNOS_THERMAL
> -	help
> -	  If you say yes here you get support for EXYNOS TMU
> -	  (Thermal Management Unit) common registration/unregistration
> -	  functions to the core thermal layer and also to use the generic
> -	  CPU cooling APIs.
> -- 
> 2.0.0.rc2
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] thermal: Kconfig: Remove config for not used EXYNOS_THERMAL_CORE
  2015-01-27 14:55 ` Eduardo Valentin
@ 2015-01-27 15:00   ` Lukasz Majewski
  0 siblings, 0 replies; 3+ messages in thread
From: Lukasz Majewski @ 2015-01-27 15:00 UTC (permalink / raw)
  To: Eduardo Valentin
  Cc: Paul Bolle, Zhang Rui, Linux PM list,
	linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz,
	Lukasz Majewski, Kukjin Kim, Amit Daniel Kachhap,
	Abhilash Kesavan, Abhilash Kesavan, Kukjin Kim, Chanwoo Choi

Hi Eduardo,

> On Tue, Jan 27, 2015 at 12:13:59PM +0100, Lukasz Majewski wrote:
> > After removing exynos_thermal_common.[c|h] files the
> > CONFIG_EXYNOS_THERMA_CORE is not needed anymore.
> > This patch removes this entry from Kconfig.
> > 
> > Reported-by: Paul Bolle <pebolle@tiscali.nl>
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> 
> This patch looks fine to me and I am about to queue it in my fixes
> tree. However, you must carry along another patch to remove this
> entry: arch/arm/configs/exynos_defconfig:CONFIG_EXYNOS_THERMAL_CORE=y

OK.

> 
> Can you please post it and ask Kim to queue the above suggested
> removal too?

OK.

> 
> > ---
> >  drivers/thermal/samsung/Kconfig | 9 ---------
> >  1 file changed, 9 deletions(-)
> > 
> > diff --git a/drivers/thermal/samsung/Kconfig
> > b/drivers/thermal/samsung/Kconfig index c43306e..c8e35c1 100644
> > --- a/drivers/thermal/samsung/Kconfig
> > +++ b/drivers/thermal/samsung/Kconfig
> > @@ -7,12 +7,3 @@ config EXYNOS_THERMAL
> >  	  the TMU, reports temperature and handles cooling action
> > if defined. This driver uses the Exynos core thermal APIs and TMU
> > configuration data from the supported SoCs.
> > -
> > -config EXYNOS_THERMAL_CORE
> > -	bool "Core thermal framework support for EXYNOS SOCs"
> > -	depends on EXYNOS_THERMAL
> > -	help
> > -	  If you say yes here you get support for EXYNOS TMU
> > -	  (Thermal Management Unit) common
> > registration/unregistration
> > -	  functions to the core thermal layer and also to use the
> > generic
> > -	  CPU cooling APIs.
> > -- 
> > 2.0.0.rc2
> > 



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-01-27 15:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-27 11:13 [PATCH] thermal: Kconfig: Remove config for not used EXYNOS_THERMAL_CORE Lukasz Majewski
2015-01-27 14:55 ` Eduardo Valentin
2015-01-27 15:00   ` Lukasz Majewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).