Re: [PATCH] dt-bindings: document qcom tsens thermal

[Eduardo Valentin <edubezval@gmail.com>]

On Mon, Jan 26, 2015 at 08:08:07PM -0800, Narendran Rajan wrote:
> Add binding documentation for the QCOM tsens device tree node
> ---
>  .../devicetree/bindings/thermal/qcom-thermal.txt   | 58 ++++++++++++++++++++++
>  1 file changed, 58 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/thermal/qcom-thermal.txt
> 
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-thermal.txt b/Documentation/devicetree/bindings/thermal/qcom-thermal.txt
> new file mode 100644
> index 0000000..d2e99d6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/qcom-thermal.txt
> @@ -0,0 +1,58 @@
> +* QCOM SoC Temperature Sensor (TSENS)
> +
> +Required properties:
> +- compatible : "qcom,ipq806x-tsens"
> +- interrupts : The interrupt number to the cpu. The interrupt specifier format
> +	       depends on the interrupt controller.
> +- qcom,imem : Must contain phandle to imem syscon node
> +- qcom,tsens-base : Must contain phandle to clock controller node
> +- qcom,calib-offsets : Must contain offsets to primary and secondary
> +			calibration data within imem
> +- qcom,tsens-slopes : Must contain slope value for each of the sensors controlled
> +			by this device

Can you please check if the above two properties can be mapped into the
'coefficients' property? It is an optional property of the thermal zone
node.

Check Documentation/devicetree/bindings/thermal/thermal.txt

However, it might require additional implementation in the of thermal
code, as we still have not got that done in any other driver.

My concern here is to avoid adding specific DT entries while we already
defined generic options that can be used.

> +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description.
> +
> +Exiample:

s/Exiample/Example/g

> +tsens: tsens-msm8960 {
> +		compatible = "qcom,ipq806x-tsens";
> +		interrupts = <0 178 1>;
> +		qcom,imem = <&imem>;
> +		qcom,tsens-base = <&gcc>;
> +		qcom,calib-offsets = <0x400 0x410>;
> +		qcom,tsens-slopes = <1176 1176 1154 1176 1111
> +				1132 1132 1199 1132 1199
> +				1132>;
> +		#thermal-sensor-cells = <1>;
> +	};
> +
> +Example: referring to thermal sensors:
> +thermal-zones {
> +	cpu_thermal: cpu_thermal {
> +		polling-delay-passive = <1000>; /* milliseconds */
> +		polling-delay = <5000>; /* milliseconds */
> +
> +		/* sensor	ID */
> +		thermal-sensors = <&tsens	1>;
> +

Something like:
                coefficients =          <[slope] [offset]>;


> +		trips {
> +			cpu_alert0: cpu_alert {
> +				temperature = <80000>; /* millicelsius */
> +				hysteresis = <2000>; /* millicelsius */
> +				type = "passive";
> +			};
> +			cpu_crit: cpu_crit {
> +				temperature = <120000>; /* millicelsius */
> +				hysteresis = <2000>; /* millicelsius */
> +				type = "critical";
> +			};
> +		};
> +
> +		cooling-maps {
> +			map0 {
> +				trip = <&cpu_alert0>;
> +				cooling-device =
> +					<&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> +			};
> +		};
> +	};
> +};
> -- 
> Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
>