Re: [PATCH] thermal: Add msm tsens thermal sensor driver

[Eduardo Valentin <edubezval@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]

On Thu, Jan 29, 2015 at 05:42:53PM -0800, Narendran Rajan wrote:

<cut>

> > 
> > 
> 
> Is not used when compiled with upstream kernel.  
> Wanted to keep a common code base with a downstream kernel which has this
> support. 

Please, keep in mind that vanilla kernels at kernel.org never maintains
compatibility to code outside the tree. You either remove the unused
code, or port the full feature, if that makes sense.

> But in my tests, yet to observe any noticeable advantage for this driver
> with HW trips.

I see. That seams to be the final common conclusion of developers that
write code for chips with such feature, once they port to the linux
kernel thermal framework. We may need a good use case to get that
ported.

> May be I need to run more tests, collect data points. 
> 

OK. Let me know your results or if you have any insights regarding HW
trip points.

> Let me revise my patch with this code removed completely.
> 


sounds good.

BR,

Eduardo Valentin

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]