From: Nishanth Menon <nm@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Eduardo Valentin <edubezval@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, Grygorii.Strashko@linaro.org
Subject: Re: [PATCH] thermal: ti-soc-thermal: fix compilation warnings when !CONFIG_PM_SLEEP
Date: Mon, 9 Feb 2015 09:00:09 -0600 [thread overview]
Message-ID: <20150209150009.GA21362@kahuna> (raw)
In-Reply-To: <alpine.DEB.2.02.1502062259190.3767@utopia.booyaka.com>
On 00:17-20150207, Paul Walmsley wrote:
>
> When CONFIG_PM_SLEEP=n, the following compilation warnings appear:
>
> drivers/thermal/ti-soc-thermal/ti-bandgap.c:1478:12: warning: ‘ti_bandgap_suspend’ defined but not used [-Wunused-function]
> static int ti_bandgap_suspend(struct device *dev)
> ^
> drivers/thermal/ti-soc-thermal/ti-bandgap.c:1492:12: warning: ‘ti_bandgap_resume’ defined but not used [-Wunused-function]
> static int ti_bandgap_resume(struct device *dev)
>
> A few years ago, suspend/resume-related code was protected by CONFIG_PM.
> But that was changed and now it's protected by CONFIG_PM_SLEEP. Fix the
> warnings by converting the preprocessor test in the TI bandgap thermal
> sensor driver from testing CONFIG_PM to testing CONFIG_PM_SLEEP.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: linux-pm@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
>
> Non-critical. Targeted for either v3.20-rc1 or v3.21-rc1.
>
> Basic test reports for a series that includes this patch (and a few other
> unrelated warning cleanups) is available here:
>
> http://www.pwsan.com/omap/testlogs/fix-omap-warnings-v3.21/20150206154619/
>
> Compare to:
>
> http://www.pwsan.com/omap/testlogs/test_v3.19-rc7/20150204213018/
>
> drivers/thermal/ti-soc-thermal/ti-bandgap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> index 634b6ce0e63a..62a5d449c388 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> @@ -1402,7 +1402,7 @@ int ti_bandgap_remove(struct platform_device *pdev)
> return 0;
> }
>
> -#ifdef CONFIG_PM
> +#ifdef CONFIG_PM_SLEEP
> static int ti_bandgap_save_ctxt(struct ti_bandgap *bgp)
> {
> int i;
> --
> 2.1.4
I am a little confused:
https://patchwork.kernel.org/patch/5792411/ was already posted. would
you suggest improvements?
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2015-02-09 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-07 0:17 [PATCH] thermal: ti-soc-thermal: fix compilation warnings when !CONFIG_PM_SLEEP Paul Walmsley
2015-02-09 15:00 ` Nishanth Menon [this message]
2015-02-09 15:53 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150209150009.GA21362@kahuna \
--to=nm@ti.com \
--cc=Grygorii.Strashko@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox