From: Nishanth Menon <nm@ti.com>
To: grygorii.strashko@linaro.org
Cc: Eduardo Valentin <edubezval@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
sumit.semwal@linaro.org, linux-omap@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] thermal: ti-soc-thermal: bandgap: Fix build warning if !CONFIG_PM_SLEEP
Date: Mon, 9 Feb 2015 09:01:06 -0600 [thread overview]
Message-ID: <20150209150106.GB21362@kahuna> (raw)
In-Reply-To: <1423234546-10458-1-git-send-email-grygorii.strashko@linaro.org>
On 16:55-20150206, grygorii.strashko@linaro.org wrote:
> From: Grygorii Strashko <Grygorii.Strashko@linaro.org>
>
> Fix following build warning if CONFIG_PM_SLEEP is not set:
>
> drivers/thermal/ti-soc-thermal/ti-bandgap.c:1478:12: warning: 'ti_bandgap_suspend' defined but not used [-Wunused-function]
> static int ti_bandgap_suspend(struct device *dev)
> ^
> drivers/thermal/ti-soc-thermal/ti-bandgap.c:1492:12: warning: 'ti_bandgap_resume' defined but not used [-Wunused-function]
> static int ti_bandgap_resume(struct device *dev)
> ^
> Signed-off-by: Grygorii Strashko <Grygorii.Strashko@linaro.org>
> ---
> drivers/thermal/ti-soc-thermal/ti-bandgap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> index 74c0e34..5d46660 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> @@ -1402,7 +1402,7 @@ int ti_bandgap_remove(struct platform_device *pdev)
> return 0;
> }
>
> -#ifdef CONFIG_PM
> +#ifdef CONFIG_PM_SLEEP
> static int ti_bandgap_save_ctxt(struct ti_bandgap *bgp)
> {
> int i;
> --
> 1.9.1
>
Suggest aligning with Paul as well:
https://patchwork.kernel.org/patch/5795391/
Otherwise:
Acked-by: Nishanth Menon <nm@ti.com>
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2015-02-09 15:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 14:55 [PATCH] thermal: ti-soc-thermal: bandgap: Fix build warning if !CONFIG_PM_SLEEP grygorii.strashko
2015-02-09 15:01 ` Nishanth Menon [this message]
2015-02-24 16:01 ` Grygorii.Strashko@linaro.org
2015-02-24 18:03 ` Eduardo Valentin
2015-02-25 8:44 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150209150106.GB21362@kahuna \
--to=nm@ti.com \
--cc=edubezval@gmail.com \
--cc=grygorii.strashko@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=sumit.semwal@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox