From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Fu, Zhonghui" <zhonghui.fu@linux.intel.com>
Cc: "rjw@rjwysocki.net >> Rafael J. Wysocki" <rjw@rjwysocki.net>,
pavel@ucw.cz, len.brown@intel.com, linux-pm@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PM-Trace: add pm-trace support for suspending phase
Date: Tue, 10 Feb 2015 05:55:59 +0800 [thread overview]
Message-ID: <20150209215559.GA12087@kroah.com> (raw)
In-Reply-To: <54D8318B.2060703@linux.intel.com>
On Mon, Feb 09, 2015 at 12:03:23PM +0800, Fu, Zhonghui wrote:
> >From ec9c0f24e800461361eaf8b280abe4272b00772d Mon Sep 17 00:00:00 2001
> From: Zhonghui Fu <zhonghui.fu@linux.intel.com>
> Date: Mon, 9 Feb 2015 11:09:22 +0800
> Subject: [PATCH] PM-Trace: add pm-trace support for suspending phase
Why is this crud here?
>
> Occasinally, the system can't come back up after suspend/resume
> due to problems of device suspending phase. This patch make
> PM_TRACE infrastructure cover device suspending phase of
> suspend/resume process, and the information in RTC can tell
> develpers which device suspending function make system hang.
>
> Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com>
> ---
> arch/x86/include/asm/resume-trace.h | 2 +-
> drivers/base/power/main.c | 30 +++++++++++++++++++++---------
> include/linux/resume-trace.h | 2 +-
> 3 files changed, 23 insertions(+), 11 deletions(-)
>
> diff --git a/arch/x86/include/asm/resume-trace.h b/arch/x86/include/asm/resume-trace.h
> index 3ff1c2c..0ca2215 100644
> --- a/arch/x86/include/asm/resume-trace.h
> +++ b/arch/x86/include/asm/resume-trace.h
> @@ -3,7 +3,7 @@
>
> #include <asm/asm.h>
>
> -#define TRACE_RESUME(user) \
> +#define TRACE_SUSPEND_RESUME(user) \
> do { \
> if (pm_trace_enabled) { \
> const void *tracedata; \
Why rename this?
If you want to do that, do it in 2 different functions (rename first,
with justification, add new functionality in a second patch)
> @@ -1078,7 +1082,7 @@ static int device_suspend_noirq(struct device *dev)
> {
> reinit_completion(&dev->power.completion);
>
> - if (pm_async_enabled && dev->power.async_suspend) {
> + if (is_async(dev)) {
Why change this logic?
greg k-h
next prev parent reply other threads:[~2015-02-09 21:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 4:03 [PATCH] PM-Trace: add pm-trace support for suspending phase Fu, Zhonghui
2015-02-09 21:55 ` Greg Kroah-Hartman [this message]
2015-02-11 2:50 ` Fu, Zhonghui
2015-02-11 14:45 ` Fu, Zhonghui
-- strict thread matches above, loose matches on Subject: below --
2015-02-11 14:43 Fu, Zhonghui
2015-02-11 15:25 ` Rafael J. Wysocki
2015-02-12 4:48 ` Fu, Zhonghui
2015-02-12 22:24 ` Rafael J. Wysocki
2015-02-15 2:36 ` Fu, Zhonghui
2015-02-12 1:23 ` Greg Kroah-Hartman
2015-02-15 2:29 ` Fu, Zhonghui
2015-02-12 5:02 Fu, Zhonghui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150209215559.GA12087@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=zhonghui.fu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).