linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Fu, Zhonghui" <zhonghui.fu@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	pavel@ucw.cz, len.brown@intel.com, linux-pm@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PM-Trace: add pm-trace support for suspending phase
Date: Thu, 12 Feb 2015 09:23:39 +0800	[thread overview]
Message-ID: <20150212012339.GE28271@kroah.com> (raw)
In-Reply-To: <54DB6A81.3040706@linux.intel.com>

On Wed, Feb 11, 2015 at 10:43:13PM +0800, Fu, Zhonghui wrote:
> >From 2626594c03ca3b9884dd44073385c36f99a3651d Mon Sep 17 00:00:00 2001
> From: Zhonghui Fu <zhonghui.fu@linux.intel.com>
> Date: Wed, 11 Feb 2015 16:20:21 +0800
> Subject: [PATCH] PM-Trace: add pm-trace support for suspending phase
> 
> Occasionally, the system can't come back up after suspend/resume
> due to problems of device suspending phase. This patch make
> PM_TRACE infrastructure cover device suspending phase of
> suspend/resume process, and the information in RTC can tell
> developers which device suspending function make system hang.
> 
> Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com>
> ---
>  arch/x86/include/asm/pm-trace.h     |   36 +++++++++++++++++++++++++++++++++++
>  arch/x86/include/asm/resume-trace.h |   21 --------------------
>  drivers/base/power/main.c           |   20 +++++++++++++++---
>  drivers/base/power/trace.c          |    6 ++--
>  include/linux/pm-trace.h            |   35 ++++++++++++++++++++++++++++++++++
>  include/linux/resume-trace.h        |   34 ---------------------------------
>  kernel/power/main.c                 |    2 +-
>  7 files changed, 91 insertions(+), 63 deletions(-)
>  create mode 100644 arch/x86/include/asm/pm-trace.h
>  delete mode 100644 arch/x86/include/asm/resume-trace.h
>  create mode 100644 include/linux/pm-trace.h
>  delete mode 100644 include/linux/resume-trace.h

Please create patches that move files around with -M so that the rename
and changes can be reviewed much easier.  As it is, I can't see the
changes you have made here.

thanks,

greg k-h

  parent reply	other threads:[~2015-02-12  1:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11 14:43 [PATCH] PM-Trace: add pm-trace support for suspending phase Fu, Zhonghui
2015-02-11 15:25 ` Rafael J. Wysocki
2015-02-12  4:48   ` Fu, Zhonghui
2015-02-12 22:24     ` Rafael J. Wysocki
2015-02-15  2:36       ` Fu, Zhonghui
2015-02-12  1:23 ` Greg Kroah-Hartman [this message]
2015-02-15  2:29   ` Fu, Zhonghui
  -- strict thread matches above, loose matches on Subject: below --
2015-02-12  5:02 Fu, Zhonghui
2015-02-09  4:03 Fu, Zhonghui
2015-02-09 21:55 ` Greg Kroah-Hartman
2015-02-11  2:50   ` Fu, Zhonghui
2015-02-11 14:45     ` Fu, Zhonghui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150212012339.GE28271@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=zhonghui.fu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).