Re: [PATCH] power: bq27x00_battery: add bq27510 support

Alexandre Belloni
2015-02-28T13:22:25Z

Hi,

On 25/02/2015 at 23:17:48 +0100, Sebastian Reichel wrote :
> > @@ -350,6 +378,9 @@ static int bq27x00_battery_read_cyct(struct bq27x00_device_info *di)
> > {
> > int cyct;
> >
> > +
>
> spurious newline.
>
> > + if (di->chip == BQ27510)
> > + cyct = bq27x00_read(di, BQ27510_REG_CYCT, false);
> > cyct = bq27x00_read(di, BQ27x00_REG_CYCT, false);
>
> missing else?
>

Indeed, I just sent v2. However, I'm not too happy with all that if/else
layering in this driver. I'll try to rework it so that it scales better.

Regards,

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering