linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Javi Merino <javi.merino@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Eduardo Valentin <edubezval@gmail.com>,
	Zhang Rui <rui.zhang@intel.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] thermal: Fix build for !CONFIG_THERMAL
Date: Wed, 4 Mar 2015 16:02:15 +0000	[thread overview]
Message-ID: <20150304160215.GA2919@e104805> (raw)
In-Reply-To: <1425470739-16651-1-git-send-email-broonie@kernel.org>

Hi Mark,

On Wed, Mar 04, 2015 at 12:05:39PM +0000, Mark Brown wrote:
> Commit ddd4dd8ddf784 (thermal: extend the cooling device API to include
> power information) added stubs for newly introduced functions when
> !CONFIG_THERMAL but did not provide names for the parameters which is
> a syntax error causing build errors in such configurations. Add names to
> fix the issue.
> 
> Also remove an extra semicolon from power_actor_set_power() which also
> breaks the build and declare the functions as static inline to avoid
> both multiple definitions and sparse warnings.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

This is already fixed in Eduardo's tree, but apparently the fix went
in after linux-next merged its branch.  It will be picked when
linux-next merges it again.

Thanks,
Javi

      reply	other threads:[~2015-03-04 16:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04 12:05 [PATCH] thermal: Fix build for !CONFIG_THERMAL Mark Brown
2015-03-04 16:02 ` Javi Merino [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150304160215.GA2919@e104805 \
    --to=javi.merino@arm.com \
    --cc=broonie@kernel.org \
    --cc=edubezval@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).