From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v3 3/9] watchdog: at91rm9200: use the system timer syscon Date: Wed, 4 Mar 2015 09:48:33 -0800 Message-ID: <20150304174826.GA5568@roeck-us.net> References: <1425478897-27322-1-git-send-email-alexandre.belloni@free-electrons.com> <1425478897-27322-4-git-send-email-alexandre.belloni@free-electrons.com> <54F71C07.6070204@roeck-us.net> <20150304150815.GG3989@piout.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150304150815.GG3989@piout.net> Sender: linux-kernel-owner@vger.kernel.org To: Alexandre Belloni Cc: Nicolas Ferre , Daniel Lezcano , Boris Brezillon , Jean-Christophe Plagniol-Villard , Thomas Gleixner , Lee Jones , Wim Van Sebroeck , Sebastian Reichel , Dmitry Eremin-Solenikov , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, linux-pm@vger.kernel.org List-Id: linux-pm@vger.kernel.org On Wed, Mar 04, 2015 at 04:08:15PM +0100, Alexandre Belloni wrote: > On 04/03/2015 at 06:51:51 -0800, Guenter Roeck wrote : > > >@@ -267,7 +276,7 @@ static struct platform_driver at91wdt_driver = { > > > .suspend = at91wdt_suspend, > > > .resume = at91wdt_resume, > > > .driver = { > > >- .name = "at91_wdt", > > >+ .name = "atmel_st_watchdog", > > > > If you change the driver name you also need to change the MODULE_ALIAS > > a few lines down. > > > > But why change it in the first place ? Maybe that was discussed somewhere, > > but not here where it belongs, and not in patch 0/9 either. > > > > That's because it conflicts with drivers/watchdog/at91sam9_wdt.c > You still have to update MODULE_ALIAS (or drop it if it is not needed anymore). Guenter > I'm not sure that is relevant anymore as they will only be probed using > DT now. > > > -- > Alexandre Belloni, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com