From: "Pali Rohár" <pali.rohar@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Grazvydas Ignotas <notasas@gmail.com>,
ivo.g.dimitrov.75@gmail.com, Samuel Ortiz <sameo@linux.intel.com>,
khilman@kernel.org, NeilBrown <neilb@suse.de>,
sre@debian.org, linux-pm@vger.kernel.org,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
kernel list <linux-kernel@vger.kernel.org>,
Sebastian Reichel <sre@kernel.org>,
GTA04 owners <gta04-owner@goldelico.com>,
sre@ring0.de, Tony Lindgren <tony@atomide.com>,
David Woodhouse <dwmw2@infradead.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>,
patrikbachan@gmail.com,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: twl4030_charger: need changes to get probed?
Date: Fri, 6 Mar 2015 23:56:06 +0100 [thread overview]
Message-ID: <201503062356.06110@pali> (raw)
In-Reply-To: <20150306224034.GA20559@amd>
[-- Attachment #1: Type: Text/Plain, Size: 1357 bytes --]
On Friday 06 March 2015 23:40:34 Pavel Machek wrote:
> On Sat 2015-03-07 00:12:07, Grazvydas Ignotas wrote:
> > On Fri, Mar 6, 2015 at 11:57 PM, Pali Rohár
> > <pali.rohar@gmail.com> wrote:
> > > On Friday 06 March 2015 22:24:17 Pavel Machek wrote:
> > >> Hi!
> > >>
> > >> According to n900 dts, twl4030-bci (aka charger) should
> > >> be included.
> > >
> > > AFAIK it is not present on n900...
> >
> > Right, it uses twl5030 variant without the charger, charging
> > on n900 is provided by separate chip and for a good reason
> > as twl's charger is not that good. Forcing the driver to
> > load just ends up with it accessing non-existent registers
> > over i2c.
>
> Ok, but:
>
> 1) Why is the twl4030-bci enabled in n900's dts, then
>
maybe it is bug in n900 dts...
Grazvydas, is there some runtime check if twl4030/twl5030 chip
has charger or not? or do we need to explicitly disable device
twl4030-bci in DT?
> and
>
> 2) When it is enabled, why it does not load?
>
> (I guess there's no way to get to input voltage on n900...?)
>
> Pavel
you can read voltage only from rx51_battery.ko (TWL ADC) or
bq27x00_battery.ko
look for Nokia_N900_RX-51_Schematics.pdf file where you can find
information what is connected to ADC and bq27200 chip.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2015-03-06 22:56 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 4:33 [PATCH 00/15] Enhance twl4030_charger functionality NeilBrown
2015-02-24 4:33 ` [PATCH 03/15] twl4030_charger: use devres for power_supply_register and kzalloc NeilBrown
2015-03-07 20:25 ` Sebastian Reichel
2015-02-24 4:33 ` [PATCH 02/15] twl4030_charger: use devm_request_threaded_irq NeilBrown
2015-02-24 4:33 ` [PATCH 01/15] power_supply core: support use of devres to register/unregister a power supply NeilBrown
2015-02-26 2:25 ` Sebastian Reichel
2015-02-24 4:33 ` [PATCH 07/15] twl4030_charger: allow fine control of charger current NeilBrown
2015-03-02 21:05 ` Pavel Machek
2015-03-04 6:47 ` NeilBrown
2015-03-04 10:24 ` Pavel Machek
2015-03-07 20:32 ` Sebastian Reichel
2015-02-24 4:33 ` [PATCH 08/15] twl4030_charger: distinguish between USB current and 'AC' current NeilBrown
2015-03-02 21:05 ` Pavel Machek
2015-03-04 6:53 ` NeilBrown
2015-02-24 4:33 ` [PATCH 04/15] twl4030_charger: use runtime_pm to keep usb phy active while charging NeilBrown
2015-02-25 7:24 ` Lee Jones
2015-03-05 5:48 ` NeilBrown
2015-02-24 4:33 ` [PATCH 05/15] twl4030_charger: trust phy to determine when USB power is available NeilBrown
2015-02-24 4:33 ` [PATCH 06/15] twl4030_charger: split uA calculation into a function NeilBrown
2015-03-02 21:05 ` Pavel Machek
2015-03-04 9:20 ` NeilBrown
2015-02-24 4:33 ` [PATCH 11/15] twl4030_charger: enable manual enable/disable of usb charging NeilBrown
2015-03-02 21:03 ` Pavel Machek
2015-03-04 6:15 ` NeilBrown
2015-03-04 10:19 ` Pavel Machek
2015-02-24 4:33 ` [PATCH 12/15] twl4030_charger: add software controlled linear charging mode NeilBrown
2015-03-02 21:09 ` Pavel Machek
2015-03-05 6:33 ` NeilBrown
2015-03-06 21:24 ` twl4030_charger: need changes to get probed? Pavel Machek
2015-03-06 21:57 ` Pali Rohár
2015-03-06 22:12 ` Grazvydas Ignotas
2015-03-06 22:40 ` Pavel Machek
2015-03-06 22:56 ` Pali Rohár [this message]
2015-03-07 15:56 ` Grazvydas Ignotas
2015-03-07 16:43 ` Pali Rohár
2015-04-26 10:13 ` Pavel Machek
2015-03-07 21:01 ` Sebastian Reichel
2015-03-09 0:06 ` NeilBrown
2015-03-09 11:14 ` Sebastian Reichel
2015-02-24 4:33 ` [PATCH 09/15] twl4030_charger: allow max_current to be managed via sysfs NeilBrown
2015-03-02 21:05 ` Pavel Machek
2015-03-05 6:26 ` NeilBrown
2015-03-05 8:17 ` Pavel Machek
2015-03-07 20:37 ` Sebastian Reichel
2015-02-24 4:33 ` [PATCH 10/15] twl4030_charger: only draw USB current as negotiated with host NeilBrown
2015-03-02 21:05 ` Pavel Machek
2015-02-24 4:33 ` [PATCH 13/15] twl4030_charger: add ac/mode to match usb/mode NeilBrown
2015-03-02 21:13 ` Pavel Machek
2015-03-06 21:59 ` Grazvydas Ignotas
2015-03-22 23:13 ` NeilBrown
2015-02-24 4:33 ` [PATCH 14/15] twl4030_charger: Increase current carefully while watching voltage NeilBrown
2015-03-02 21:29 ` Pavel Machek
2015-03-05 6:51 ` NeilBrown
2015-02-24 4:33 ` [PATCH 15/15] twl4030_charger: assume a 'charger' can supply maximum current NeilBrown
2015-03-02 21:29 ` Pavel Machek
2015-03-05 6:45 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201503062356.06110@pali \
--to=pali.rohar@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gta04-owner@goldelico.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=neilb@suse.de \
--cc=notasas@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=pavel@ucw.cz \
--cc=sameo@linux.intel.com \
--cc=sre@debian.org \
--cc=sre@kernel.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).