* [PATCH] thermal: Do not log an error if thermal_zone_get_temp returns -EAGAIN
@ 2015-03-10 15:06 Hans de Goede
2015-03-07 6:51 ` Eduardo Valentin
2015-03-10 16:05 ` Dmitry Torokhov
0 siblings, 2 replies; 4+ messages in thread
From: Hans de Goede @ 2015-03-10 15:06 UTC (permalink / raw)
To: Zhang Rui, Eduardo Valentin
Cc: Maxime Ripard, Dmitry Torokhov, linux-pm, Hans de Goede
Some temperature sensors only get updated every few seconds and while
waiting for the first irq reporting a (new) temperature to happen there
get_temp operand will return -EAGAIN as it does not have any data to report
yet.
Not logging an error in this case avoids messages like these from showing
up in dmesg on affected systems:
[ 1.219353] thermal thermal_zone0: failed to read out thermal zone 0
[ 2.015433] thermal thermal_zone0: failed to read out thermal zone 0
[ 2.416737] thermal thermal_zone0: failed to read out thermal zone 0
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/thermal/thermal_core.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 48491d1..e3cbf34 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -458,8 +458,10 @@ static void update_temperature(struct thermal_zone_device *tz)
ret = thermal_zone_get_temp(tz, &temp);
if (ret) {
- dev_warn(&tz->device, "failed to read out thermal zone %d\n",
- tz->id);
+ if (ret != -EAGAIN)
+ dev_warn(&tz->device,
+ "failed to read out thermal zone %d\n",
+ tz->id);
return;
}
--
2.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] thermal: Do not log an error if thermal_zone_get_temp returns -EAGAIN
2015-03-10 15:06 [PATCH] thermal: Do not log an error if thermal_zone_get_temp returns -EAGAIN Hans de Goede
@ 2015-03-07 6:51 ` Eduardo Valentin
2015-03-21 13:59 ` Hans de Goede
2015-03-10 16:05 ` Dmitry Torokhov
1 sibling, 1 reply; 4+ messages in thread
From: Eduardo Valentin @ 2015-03-07 6:51 UTC (permalink / raw)
To: Hans de Goede; +Cc: Zhang Rui, Maxime Ripard, Dmitry Torokhov, linux-pm
Hans,
Thanks for fixing this. One minor request though.
On Tue, Mar 10, 2015 at 04:06:46PM +0100, Hans de Goede wrote:
> Some temperature sensors only get updated every few seconds and while
> waiting for the first irq reporting a (new) temperature to happen there
> get_temp operand will return -EAGAIN as it does not have any data to report
> yet.
>
> Not logging an error in this case avoids messages like these from showing
> up in dmesg on affected systems:
>
> [ 1.219353] thermal thermal_zone0: failed to read out thermal zone 0
> [ 2.015433] thermal thermal_zone0: failed to read out thermal zone 0
> [ 2.416737] thermal thermal_zone0: failed to read out thermal zone 0
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/thermal/thermal_core.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 48491d1..e3cbf34 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -458,8 +458,10 @@ static void update_temperature(struct thermal_zone_device *tz)
>
> ret = thermal_zone_get_temp(tz, &temp);
> if (ret) {
> - dev_warn(&tz->device, "failed to read out thermal zone %d\n",
> - tz->id);
> + if (ret != -EAGAIN)
> + dev_warn(&tz->device,
> + "failed to read out thermal zone %d\n",
> + tz->id);
Can you please take the opportunity to add the error code in the
message? Something like:
+ dev_warn(&tz->device,
+ "failed to read out thermal zone (%d)\n",
+ ret);
The thermal zone id (tz->id) is already included in the error message
as it is always appended to the thermal zone device name
("thermal_zone%d", tz->id).
BR,
Eduardo Valentin
> return;
> }
>
> --
> 2.3.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] thermal: Do not log an error if thermal_zone_get_temp returns -EAGAIN
2015-03-07 6:51 ` Eduardo Valentin
@ 2015-03-21 13:59 ` Hans de Goede
0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2015-03-21 13:59 UTC (permalink / raw)
To: Eduardo Valentin; +Cc: Zhang Rui, Maxime Ripard, Dmitry Torokhov, linux-pm
Hi,
On 07-03-15 07:51, Eduardo Valentin wrote:
> Hans,
>
> Thanks for fixing this. One minor request though.
>
> On Tue, Mar 10, 2015 at 04:06:46PM +0100, Hans de Goede wrote:
>> Some temperature sensors only get updated every few seconds and while
>> waiting for the first irq reporting a (new) temperature to happen there
>> get_temp operand will return -EAGAIN as it does not have any data to report
>> yet.
>>
>> Not logging an error in this case avoids messages like these from showing
>> up in dmesg on affected systems:
>>
>> [ 1.219353] thermal thermal_zone0: failed to read out thermal zone 0
>> [ 2.015433] thermal thermal_zone0: failed to read out thermal zone 0
>> [ 2.416737] thermal thermal_zone0: failed to read out thermal zone 0
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> drivers/thermal/thermal_core.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
>> index 48491d1..e3cbf34 100644
>> --- a/drivers/thermal/thermal_core.c
>> +++ b/drivers/thermal/thermal_core.c
>> @@ -458,8 +458,10 @@ static void update_temperature(struct thermal_zone_device *tz)
>>
>> ret = thermal_zone_get_temp(tz, &temp);
>> if (ret) {
>> - dev_warn(&tz->device, "failed to read out thermal zone %d\n",
>> - tz->id);
>> + if (ret != -EAGAIN)
>> + dev_warn(&tz->device,
>> + "failed to read out thermal zone %d\n",
>> + tz->id);
>
> Can you please take the opportunity to add the error code in the
> message? Something like:
> + dev_warn(&tz->device,
> + "failed to read out thermal zone (%d)\n",
> + ret);
>
> The thermal zone id (tz->id) is already included in the error message
> as it is always appended to the thermal zone device name
> ("thermal_zone%d", tz->id).
Ok, v2 coming up.
Regards,
Hans
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] thermal: Do not log an error if thermal_zone_get_temp returns -EAGAIN
2015-03-10 15:06 [PATCH] thermal: Do not log an error if thermal_zone_get_temp returns -EAGAIN Hans de Goede
2015-03-07 6:51 ` Eduardo Valentin
@ 2015-03-10 16:05 ` Dmitry Torokhov
1 sibling, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2015-03-10 16:05 UTC (permalink / raw)
To: Hans de Goede; +Cc: Zhang Rui, Eduardo Valentin, Maxime Ripard, linux-pm
On Tue, Mar 10, 2015 at 04:06:46PM +0100, Hans de Goede wrote:
> Some temperature sensors only get updated every few seconds and while
> waiting for the first irq reporting a (new) temperature to happen there
> get_temp operand will return -EAGAIN as it does not have any data to report
> yet.
>
> Not logging an error in this case avoids messages like these from showing
> up in dmesg on affected systems:
>
> [ 1.219353] thermal thermal_zone0: failed to read out thermal zone 0
> [ 2.015433] thermal thermal_zone0: failed to read out thermal zone 0
> [ 2.416737] thermal thermal_zone0: failed to read out thermal zone 0
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/thermal/thermal_core.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 48491d1..e3cbf34 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -458,8 +458,10 @@ static void update_temperature(struct thermal_zone_device *tz)
>
> ret = thermal_zone_get_temp(tz, &temp);
> if (ret) {
> - dev_warn(&tz->device, "failed to read out thermal zone %d\n",
> - tz->id);
> + if (ret != -EAGAIN)
> + dev_warn(&tz->device,
> + "failed to read out thermal zone %d\n",
> + tz->id);
> return;
> }
>
> --
> 2.3.1
>
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-21 13:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-10 15:06 [PATCH] thermal: Do not log an error if thermal_zone_get_temp returns -EAGAIN Hans de Goede
2015-03-07 6:51 ` Eduardo Valentin
2015-03-21 13:59 ` Hans de Goede
2015-03-10 16:05 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).