From: 'Sebastian Reichel' <sre@kernel.org>
To: "Tc, Jenny" <jenny.tc@intel.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Anton Vorontsov <anton.vorontsov@linaro.org>,
David Woodhouse <dwmw2@infradead.org>,
"jonghwa3.lee@samsung.com" <jonghwa3.lee@samsung.com>,
"myungjoo.ham@gmail.com" <myungjoo.ham@gmail.com>,
"Pallala, Ramakrishna" <ramakrishna.pallala@intel.com>
Subject: Re: [RFC 1/4] power_supply: Introduce charging object table
Date: Mon, 9 Mar 2015 15:08:32 +0100 [thread overview]
Message-ID: <20150309140831.GA950@earth> (raw)
In-Reply-To: <20ADAB092842284E95860F279283C5642EEC90C3@BGSMSX104.gar.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 415 bytes --]
Hi,
On Mon, Mar 09, 2015 at 12:26:21PM +0000, Tc, Jenny wrote:
> > > + char name[PSY_MAX_BAT_NAME_LEN];
> >
> > char *name;
> >
> > No need for arbitrary length limitation.
>
> The length limitation is introduced to form a packed structure so that
> the data can be read directly from memory without parsing.
This reason is ok for a device driver, but not for a kernel
subsystem.
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-09 14:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 12:26 [RFC 1/4] power_supply: Introduce charging object table Tc, Jenny
2015-03-09 14:08 ` 'Sebastian Reichel' [this message]
2015-03-10 5:16 ` Tc, Jenny
-- strict thread matches above, loose matches on Subject: below --
2015-03-06 10:33 [RFC 0/4] Enable power supply charging control Jenny TC
2015-03-06 10:33 ` [RFC 1/4] power_supply: Introduce charging object table Jenny TC
2015-03-06 11:12 ` Oliver Neukum
2015-03-08 1:31 ` Sebastian Reichel
2015-03-08 1:00 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309140831.GA950@earth \
--to=sre@kernel.org \
--cc=anton.vorontsov@linaro.org \
--cc=dwmw2@infradead.org \
--cc=jenny.tc@intel.com \
--cc=jonghwa3.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@gmail.com \
--cc=ramakrishna.pallala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).