linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Keita Kobayashi <keita.kobayashi.ym@renesas.com>
Cc: rjw@rjwysocki.net, daniel.lezcano@linaro.org,
	linux-sh@vger.kernel.org, linux-pm@vger.kernel.org,
	magnus.damm@gmail.com
Subject: Re: [RFC/PATCH 2/4] ARM: shmobile: Add cpuidle_ops for R-Car cpuidle
Date: Tue, 7 Apr 2015 10:50:40 +0900	[thread overview]
Message-ID: <20150407015040.GD27486@verge.net.au> (raw)
In-Reply-To: <1428292244-2160-3-git-send-email-keita.kobayashi.ym@renesas.com>

On Mon, Apr 06, 2015 at 12:50:42PM +0900, Keita Kobayashi wrote:
> This patch add Core-Standby support for R-Car cpuidle.
> 
> Signed-off-by: Keita Kobayashi <keita.kobayashi.ym@renesas.com>

[snip]

> diff --git a/arch/arm/mach-shmobile/pm-rcar-gen2.c b/arch/arm/mach-shmobile/pm-rcar-gen2.c
> index 6815781..846b8ae 100644

[snip]

> +struct cpuidle_ops rcar_cpuidle_ops __initdata = {
> +	.suspend = rcar_cpuidle_enter,
> +};
> +CPUIDLE_METHOD_OF_DECLARE(rcar, "renesas,rcar-idle", &rcar_cpuidle_ops);
> +#endif

It seems to me that that renesas,rcar-idle should be documented
as an enable-method in Documentation/devicetree/bindings/arm/cpus.txt.

That change could be a separate patch for device tree.

  reply	other threads:[~2015-04-07  1:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-06  3:50 [RFC/PATCH 0/4] Add cpuidle support for r8a7791 Keita Kobayashi
2015-04-06  3:50 ` [RFC/PATCH 1/4] ARM: cpuidle: Add cpuidle support for R-Car Gen2 series Keita Kobayashi
2015-04-07  1:44   ` Simon Horman
2015-04-07  5:48     ` keita kobayashi
2015-04-06  3:50 ` [RFC/PATCH 2/4] ARM: shmobile: Add cpuidle_ops for R-Car cpuidle Keita Kobayashi
2015-04-07  1:50   ` Simon Horman [this message]
2015-04-07  5:56     ` keita kobayashi
2015-04-06  3:50 ` [RFC/PATCH 3/4] ARM: shmobile: dtsi: Add cpuidle parameters into each cpu for r8a7791 Keita Kobayashi
2015-04-06  3:50 ` [RFC/PATCH 4/4] ARM: shmobile: Enable Renesas R-Car cpuidle for shmobile_defconfig Keita Kobayashi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150407015040.GD27486@verge.net.au \
    --to=horms@verge.net.au \
    --cc=daniel.lezcano@linaro.org \
    --cc=keita.kobayashi.ym@renesas.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).