Re: [PATCH 4/7] arm: dts: imx: update snvs to use syscon access register

Alexandre Belloni
2015-05-18T22:17:17Z

On 18/05/2015 at 14:30:50 -0500, Zhi Li wrote :
> On Mon, May 18, 2015 at 3:45 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> > Hi Frank,
> >
> > Am Freitag, den 15.05.2015, 21:36 +0800 schrieb Frank.Li@freescale.com:
> >> From: Frank Li <Frank.Li@freescale.com>
> >>
> >> snvs is MFP device. Change dts to use syscon to allocate register resource.
> >>
> >> Signed-off-by: Frank Li <Frank.Li@freescale.com>
> >> ---
> >> arch/arm/boot/dts/imx6qdl.dtsi | 12 ++++--------
> >> arch/arm/boot/dts/imx6sl.dtsi | 12 ++++--------
> >> arch/arm/boot/dts/imx6sx.dtsi | 12 ++++--------
> >> arch/arm/boot/dts/vfxxx.dtsi | 9 +++------
> >> 4 files changed, 15 insertions(+), 30 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> >> index 0482a66..6d8161d 100644
> >> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> >> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> >> @@ -687,21 +687,17 @@
> >> };
> >>
> >> snvs@020cc000 {
> >> - compatible = "fsl,sec-v4.0-mon", "simple-bus";
> >> - #address-cells = <1>;
> >> - #size-cells = <1>;
> >> - ranges = <0 0x020cc000 0x4000>;
> >> + compatible = "fsl,sec-v4.0-mon", "syscon", "simple-bus";
> >
> > The compatible should change from "simple-bus" to "simple-mfd", then.
>
> After change to simple-mfd, driver can't been probed. Anything missed?

The pull request is there:
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/342131.html

It has landed in linux-next

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering