From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
sboyd@codeaurora.org, prarit@redhat.com, skannan@codeaurora.org,
Srivatsa Bhat <srivatsa@mit.edu>
Subject: Re: [PATCH V3 14/14] cpufreq: Add support for physical hoplug of CPUs
Date: Mon, 18 May 2015 07:41:07 +0530 [thread overview]
Message-ID: <20150518021107.GA5102@linux> (raw)
In-Reply-To: <6810633.U8XLCHe8Cd@vostro.rjw.lan>
On 18-05-15, 02:30, Rafael J. Wysocki wrote:
> Well, if the sysfs directories are removed on every offline, then in particular
> they will be removed when the device is physically going away, so it should
> actually work (unless we've broken it already and nobody noticed).
The problem is that the remove routine is called twice and I thought
it might not be safe to call it twice. Ofcourse I missed the
cpu_offline() checks in the sysfs removal path.
> If you want to keep them around after offline, you need to become careful
> about the "physical hot-remove" case at the same time (and not several patches
> later).
Sure, will do that today.
--
viresh
prev parent reply other threads:[~2015-05-18 2:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 6:23 [PATCH V3 00/14] cpufreq: Don't loose cpufreq history on CPU hotplug Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 01/14] cpufreq: Create for_each_{in}active_policy() Viresh Kumar
2015-05-08 21:46 ` Rafael J. Wysocki
2015-05-09 2:27 ` Viresh Kumar
2015-05-12 6:04 ` Viresh Kumar
2015-05-12 6:50 ` [PATCH V4 " Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 02/14] cpufreq: Don't clear cpufreq_cpu_data and policy list for inactive policies Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 03/14] cpufreq: Get rid of cpufreq_cpu_data_fallback Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 04/14] cpufreq: Don't traverse all active policies to find policy for a cpu Viresh Kumar
2015-05-12 6:52 ` [PATCH V4 " Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 05/14] cpufreq: Manage governor usage history with 'policy->last_governor' Viresh Kumar
2015-05-12 6:52 ` [PATCH V4 " Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 06/14] cpufreq: Mark policy->governor = NULL for inactive policies Viresh Kumar
2015-05-12 6:52 ` [PATCH V4 " Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 07/14] cpufreq: Don't allow updating inactive-policies from sysfs Viresh Kumar
2015-05-16 1:10 ` Rafael J. Wysocki
2015-05-16 2:01 ` Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 08/14] cpufreq: Track cpu managing sysfs kobjects separately Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 09/14] cpufreq: Stop migrating sysfs files on hotplug Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 10/14] cpufreq: Remove cpufreq_update_policy() Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 11/14] cpufreq: Initialize policy->kobj while allocating policy Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 12/14] cpufreq: Call cpufreq_policy_put_kobj() from cpufreq_policy_free() Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 13/14] cpufreq: Restart governor as soon as possible Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 14/14] cpufreq: Add support for physical hoplug of CPUs Viresh Kumar
2015-05-16 1:18 ` Rafael J. Wysocki
2015-05-16 2:13 ` Viresh Kumar
2015-05-18 0:30 ` Rafael J. Wysocki
2015-05-18 2:11 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518021107.GA5102@linux \
--to=viresh.kumar@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=skannan@codeaurora.org \
--cc=srivatsa@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).