Hi, On Mon, May 18, 2015 at 10:45:07PM +0200, Uwe Kleine-König wrote: > devm_gpiod_get_optional returns NULL if devm_gpiod_get would return an > ENOENT error pointer. > > There is no semantic change intended. > > Signed-off-by: Uwe Kleine-König Thanks, queued. > probably you could argue if the other errors returned by > devm_gpiod_get_optional should be ignored or not. I'd say it would be cleaner > to forward the error but as the driver explictly claims it should be ok, I > kept this behaviour. > > For forwarding the error replace "data->gpio_trigger = NULL" by > "return PTR_ERR(data->gpio_trigger)". Looks sensible, but I took the patch as is for now, since I can't test the changes (I don't have any ltc2952 including devices). Also it should be a second patch, so that it can be reverted if needed. -- Sebastian