* [PATCH 1/1] power_supply: 88pm860x_charger: Do not call free_irq() twice
@ 2015-05-29 13:16 Takeshi Yoshimura
2015-05-29 14:34 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Takeshi Yoshimura @ 2015-05-29 13:16 UTC (permalink / raw)
To: Sebastian Reichel, Dmitry Eremin-Solenikov, David Woodhouse,
linux-pm
Cc: linux-kernel, Takeshi Yoshimura
My static checker detected double free_irq() in pm860x_charger_remove().
Unloading this module always causes a warning. This patch removes the
first redundant free_irq() call.
Signed-off-by: Takeshi Yoshimura <yos@sslab.ics.keio.ac.jp>
---
drivers/power/88pm860x_charger.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/power/88pm860x_charger.c b/drivers/power/88pm860x_charger.c
index 0e448c6..297e72d 100644
--- a/drivers/power/88pm860x_charger.c
+++ b/drivers/power/88pm860x_charger.c
@@ -742,7 +742,6 @@ static int pm860x_charger_remove(struct platform_device *pdev)
int i;
power_supply_unregister(info->usb);
- free_irq(info->irq[0], info);
for (i = 0; i < info->irq_nums; i++)
free_irq(info->irq[i], info);
return 0;
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] power_supply: 88pm860x_charger: Do not call free_irq() twice
2015-05-29 13:16 [PATCH 1/1] power_supply: 88pm860x_charger: Do not call free_irq() twice Takeshi Yoshimura
@ 2015-05-29 14:34 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2015-05-29 14:34 UTC (permalink / raw)
To: Takeshi Yoshimura
Cc: Dmitry Eremin-Solenikov, David Woodhouse, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 293 bytes --]
Hi,
On Fri, May 29, 2015 at 01:16:43PM +0000, Takeshi Yoshimura wrote:
> My static checker detected double free_irq() in pm860x_charger_remove().
> Unloading this module always causes a warning. This patch removes the
> first redundant free_irq() call.
Thanks, queued for 4.2.
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-29 14:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-29 13:16 [PATCH 1/1] power_supply: 88pm860x_charger: Do not call free_irq() twice Takeshi Yoshimura
2015-05-29 14:34 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).