[PATCH] power: reset: gpio-restart: increase priority slightly

[PATCH] power: reset: gpio-restart: increase priority slightly

[Heiko Stübner]

gpio-restart uses a priority of 128 and currently most soc-level restart
mechanisms use the same - with some exceptions even using 192.
But while the soc-level restarts are provided by the soc itself,
gpio-restarts will most of the time be board-specfic and be used
when some special board condition makes the soc-level restart
only a second choice.

The problem at hand manifested itself on the rk3288-veyron devices.
While the soc-level restart can sucessfully restart all other rockchip
boards I have, the veyron devices use an external restart mechanism that
seems to not only reset the soc but also some external needed components.

With both restart handlers having priority 128 in my tests the soc-specific
variant took precedent in all cases. While it could restart the soc
sucessfully in all cases, firmware then got an issue when talking to an
external component, resulting in the device being put into recovery mode.

So, give the board-specific restart handler a slight push and move it
to priority 129 to make it more important than the generic soc-specific
restart-handler.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 drivers/power/reset/gpio-restart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/reset/gpio-restart.c b/drivers/power/reset/gpio-restart.c
index edb327e..829b45f 100644
--- a/drivers/power/reset/gpio-restart.c
+++ b/drivers/power/reset/gpio-restart.c
@@ -78,7 +78,7 @@ static int gpio_restart_probe(struct platform_device *pdev)
 	}
 
 	gpio_restart->restart_handler.notifier_call = gpio_restart_notify;
-	gpio_restart->restart_handler.priority = 128;
+	gpio_restart->restart_handler.priority = 129;
 	gpio_restart->active_delay_ms = 100;
 	gpio_restart->inactive_delay_ms = 100;
 	gpio_restart->wait_delay_ms = 3000;
-- 
2.1.4

Re: [PATCH] power: reset: gpio-restart: increase priority slightly

[Guenter Roeck]

On 06/02/2015 07:48 AM, Heiko Stübner wrote:
> gpio-restart uses a priority of 128 and currently most soc-level restart
> mechanisms use the same - with some exceptions even using 192.
> But while the soc-level restarts are provided by the soc itself,
> gpio-restarts will most of the time be board-specfic and be used
> when some special board condition makes the soc-level restart
> only a second choice.
>
> The problem at hand manifested itself on the rk3288-veyron devices.
> While the soc-level restart can sucessfully restart all other rockchip
> boards I have, the veyron devices use an external restart mechanism that
> seems to not only reset the soc but also some external needed components.
>
> With both restart handlers having priority 128 in my tests the soc-specific
> variant took precedent in all cases. While it could restart the soc
> sucessfully in all cases, firmware then got an issue when talking to an
> external component, resulting in the device being put into recovery mode.
>
> So, give the board-specific restart handler a slight push and move it
> to priority 129 to make it more important than the generic soc-specific
> restart-handler.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Makes sense.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Re: [PATCH] power: reset: gpio-restart: increase priority slightly

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 1323 bytes --]

Hi Heiko,

On Tue, Jun 02, 2015 at 04:48:50PM +0200, Heiko Stübner wrote:
> gpio-restart uses a priority of 128 and currently most soc-level restart
> mechanisms use the same - with some exceptions even using 192.
> But while the soc-level restarts are provided by the soc itself,
> gpio-restarts will most of the time be board-specfic and be used
> when some special board condition makes the soc-level restart
> only a second choice.
> 
> The problem at hand manifested itself on the rk3288-veyron devices.
> While the soc-level restart can sucessfully restart all other rockchip
> boards I have, the veyron devices use an external restart mechanism that
> seems to not only reset the soc but also some external needed components.
> 
> With both restart handlers having priority 128 in my tests the soc-specific
> variant took precedent in all cases. While it could restart the soc
> sucessfully in all cases, firmware then got an issue when talking to an
> external component, resulting in the device being put into recovery mode.
> 
> So, give the board-specific restart handler a slight push and move it
> to priority 129 to make it more important than the generic soc-specific
> restart-handler.
> 
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Thanks, queued for 4.2.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]