From: Pavel Machek <pavel@ucw.cz>
To: Nitish Ambastha <nitish.a@samsung.com>
Cc: rjw@rjwysocki.net, len.brown@intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, cpgs@samsung.com,
nits.ambastha@gmail.com
Subject: Re: [PATCH 1/1] kernel/power/autosleep.c: check for pm_suspend() return before queueing suspend again
Date: Mon, 29 Jun 2015 11:21:00 +0200 [thread overview]
Message-ID: <20150629092100.GA7617@amd> (raw)
In-Reply-To: <1435581297-20271-1-git-send-email-nitish.a@samsung.com>
On Mon 2015-06-29 18:04:57, Nitish Ambastha wrote:
> Prevent tight loop for suspend-resume when some
> devices failed to suspend
> If some devices failed to suspend, we monitor this
> error in try_to_suspend(). pm_suspend() is already
> an 'int' returning function, how about checking return
> from pm_suspend() before queueing suspend again?
>
> For devices which do not register for pending events,
> this will prevent tight loop for suspend-resume in
> suspend abort scenarios due to device suspend failures
Umm. I guess code could be rearranged so that wait entry is shared
with the already existing case?
Plus, I don't think "INFO" is right log level for failure...
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-06-29 9:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 12:34 [PATCH 1/1] kernel/power/autosleep.c: check for pm_suspend() return before queueing suspend again Nitish Ambastha
2015-06-29 9:21 ` Pavel Machek [this message]
2015-06-29 18:54 ` [PATCHv2 " Nitish Ambastha
2015-06-29 19:56 ` Rafael J. Wysocki
2015-06-29 20:07 ` Rafael J. Wysocki
2015-06-30 19:22 ` Nitish Ambastha
2015-06-30 20:01 ` Rafael J. Wysocki
2015-07-04 18:06 ` Nitish Ambastha
2015-07-13 20:08 ` [PATCHv3 " Nitish Ambastha
2015-07-13 20:24 ` Nitish Ambastha
2015-07-13 23:43 ` Rafael J. Wysocki
2015-07-14 4:04 ` Nitish Ambastha
2015-07-15 22:29 ` Rafael J. Wysocki
2015-07-22 20:11 ` Nitish Ambastha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150629092100.GA7617@amd \
--to=pavel@ucw.cz \
--cc=cpgs@samsung.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nitish.a@samsung.com \
--cc=nits.ambastha@gmail.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).