From: Pavel Machek <pavel@ucw.cz>
To: Dave Chinner <david@fromorbit.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Alan Stern <stern@rowland.harvard.edu>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Linux PM list <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Len Brown <len.brown@intel.com>
Subject: Re: [PATCH 1/1] suspend: delete sys_sync()
Date: Mon, 6 Jul 2015 13:11:05 +0200 [thread overview]
Message-ID: <20150706111105.GD381@amd> (raw)
In-Reply-To: <20150706000614.GB3902@dastard>
Hi!
> > Moreover, question is if we really need to carry out the sync on *every*
> > suspend even if it is not pointless overall. That shouldn't really be
> > necessary if we suspend and resume often enough or if we resume only for
> > a while and then suspend again. Maybe it should be rate limited somehow
> > at least?
>
> If you suspend and resume frequently, then the cost of the sync
> shoul dbe negliable because the amount of data dirtied between
> resume/suspend shoul dbe negliable. hence my questions about where
> sync is spending too much time, and whether we've actually fixed
> those problems or not. If sync speed on clean filesystems is a
> problem then we need to fix sync, not work around it.
And yes, that's solution I'd really prefer over adding knobs to
suspend.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-07-06 11:11 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 7:08 [PATCH 1/1] suspend: delete sys_sync() Len Brown
2015-05-08 14:34 ` Alan Stern
2015-05-08 16:36 ` Len Brown
2015-05-08 19:13 ` One Thousand Gnomes
2015-05-08 19:32 ` Len Brown
2015-05-08 19:52 ` One Thousand Gnomes
2015-05-08 20:39 ` Rafael J. Wysocki
2015-05-08 20:30 ` Rafael J. Wysocki
2015-05-09 19:59 ` Alan Stern
2015-05-09 20:25 ` Henrique de Moraes Holschuh
2015-05-11 20:34 ` Len Brown
2015-05-12 6:11 ` Oliver Neukum
2015-06-25 17:11 ` Henrique de Moraes Holschuh
2015-06-30 20:04 ` Len Brown
2015-07-01 12:21 ` Henrique de Moraes Holschuh
2015-07-02 3:07 ` Len Brown
2015-07-03 1:42 ` Dave Chinner
2015-07-04 1:03 ` Rafael J. Wysocki
2015-07-04 8:50 ` Geert Uytterhoeven
2015-07-05 23:25 ` Rafael J. Wysocki
2015-07-04 14:19 ` Alan Stern
2015-07-05 23:28 ` Rafael J. Wysocki
2015-07-06 11:06 ` Pavel Machek
2015-07-06 13:59 ` Rafael J. Wysocki
2015-07-07 10:25 ` Pavel Machek
2015-07-07 12:22 ` Rafael J. Wysocki
2015-07-06 0:06 ` Dave Chinner
2015-07-06 11:11 ` Pavel Machek [this message]
2015-07-06 13:52 ` Rafael J. Wysocki
2015-07-07 1:17 ` Dave Chinner
2015-07-07 12:14 ` Rafael J. Wysocki
2015-07-07 13:16 ` Oliver Neukum
2015-07-07 14:32 ` Rafael J. Wysocki
2015-07-07 14:38 ` Oliver Neukum
2015-07-07 15:03 ` Alan Stern
2015-07-07 22:20 ` Rafael J. Wysocki
2015-07-08 11:20 ` Pavel Machek
2015-07-08 14:40 ` Alan Stern
2015-07-08 22:04 ` Rafael J. Wysocki
2015-07-07 22:11 ` Rafael J. Wysocki
2015-07-08 7:51 ` Oliver Neukum
2015-07-08 22:03 ` Rafael J. Wysocki
2015-07-09 7:32 ` Oliver Neukum
2015-07-09 23:22 ` Rafael J. Wysocki
2015-08-04 19:54 ` Pavel Machek
2015-07-08 11:17 ` Pavel Machek
2015-07-07 13:42 ` Takashi Iwai
2015-07-06 10:15 ` Ming Lei
2015-07-06 10:03 ` Pavel Machek
2015-05-11 1:44 ` Dave Chinner
2015-05-11 20:22 ` Len Brown
2015-05-12 22:34 ` Dave Chinner
2015-05-13 23:22 ` NeilBrown
2015-05-14 23:54 ` Dave Chinner
2015-05-15 0:34 ` Rafael J. Wysocki
2015-05-15 0:40 ` Ming Lei
2015-05-15 0:59 ` Rafael J. Wysocki
2015-05-15 5:13 ` Ming Lei
2015-05-15 10:35 ` One Thousand Gnomes
2015-05-18 1:57 ` NeilBrown
[not found] ` <CAJvTdKn_0EZ0ZuqO2e4+ExD8kFWcy78fse4zHr3uFZODOroXEg@mail.gmail.com>
2015-06-19 1:09 ` Dave Chinner
2015-06-19 2:35 ` Len Brown
2015-06-19 4:31 ` Dave Chinner
2015-06-19 6:34 ` Len Brown
2015-06-19 23:07 ` Dave Chinner
2015-06-20 5:26 ` Len Brown
2015-05-15 1:04 ` NeilBrown
2015-05-15 14:20 ` Alan Stern
2015-05-15 14:32 ` Alan Stern
2015-05-15 14:19 ` Alan Stern
2015-07-06 10:07 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706111105.GD381@amd \
--to=pavel@ucw.cz \
--cc=david@fromorbit.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=hmh@hmh.eng.br \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).