From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Yan Subject: Re: [RFCv5 PATCH 27/46] sched, cpuidle: Track cpuidle state index in the scheduler Date: Tue, 21 Jul 2015 14:41:10 +0800 Message-ID: <20150721064110.GA21501@leoy-linaro> References: <1436293469-25707-1-git-send-email-morten.rasmussen@arm.com> <1436293469-25707-28-git-send-email-morten.rasmussen@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pd0-f170.google.com ([209.85.192.170]:33359 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbbGUGlS (ORCPT ); Tue, 21 Jul 2015 02:41:18 -0400 Received: by pdbnt7 with SMTP id nt7so43464046pdb.0 for ; Mon, 20 Jul 2015 23:41:17 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1436293469-25707-28-git-send-email-morten.rasmussen@arm.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Morten Rasmussen Cc: peterz@infradead.org, mingo@redhat.com, vincent.guittot@linaro.org, daniel.lezcano@linaro.org, Dietmar Eggemann , yuyang.du@intel.com, mturquette@baylibre.com, rjw@rjwysocki.net, Juri Lelli , sgurrappadi@nvidia.com, pang.xunlei@zte.com.cn, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Hi Morten, On Tue, Jul 07, 2015 at 07:24:10PM +0100, Morten Rasmussen wrote: > The idle-state of each cpu is currently pointed to by rq->idle_state but > there isn't any information in the struct cpuidle_state that can used to > look up the idle-state energy model data stored in struct > sched_group_energy. For this purpose is necessary to store the idle > state index as well. Ideally, the idle-state data should be unified. > > cc: Ingo Molnar > cc: Peter Zijlstra > > Signed-off-by: Morten Rasmussen This patch should re-base with latest kernel; otherwise it will have conflict with below commits: 827a5ae sched / idle: Call default_idle_call() from cpuidle_enter_state() faad384 sched / idle: Call idle_set_state() from cpuidle_enter_state() bcf6ad8 sched / idle: Eliminate the "reflect" check from cpuidle_idle_call() 82f6632 sched / idle: Move the default idle call code to a separate function Thanks, Leo Yan