From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sascha Hauer Subject: Re: [PATCH] thermal: consistently use int for temperatures Date: Tue, 21 Jul 2015 09:31:11 +0200 Message-ID: <20150721073111.GH5161@pengutronix.de> References: <1436167189-29835-1-git-send-email-s.hauer@pengutronix.de> <9hhd1zrc9yb.fsf@e105922-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:60058 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752797AbbGUHb1 (ORCPT ); Tue, 21 Jul 2015 03:31:27 -0400 Content-Disposition: inline In-Reply-To: <9hhd1zrc9yb.fsf@e105922-lin.cambridge.arm.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Punit Agrawal Cc: linux-pm@vger.kernel.org, Zhang Rui , Eduardo Valentin , linux-kernel@vger.kernel.org, Jean Delvare , Peter Feuerer , Heiko Stuebner , Lukasz Majewski , Stephen Warren , Thierry Reding , linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Guenter Roeck , "Rafael J. Wysocki" , Maxime Ripard , Darren Hart , lm-sensors@lm-sensors.org Hi Punit, On Fri, Jul 17, 2015 at 12:14:36PM +0100, Punit Agrawal wrote: > Hi Sascha, >=20 > Sascha Hauer writes: >=20 > > The thermal code uses int, long and unsigned long for temperatures > > in different places. > > > > Using an unsigned type limits the thermal framework to positive > > temperatures without need. Also several drivers currently will repo= rt > > temperatures near UINT_MAX for temperatures below 0=B0C. This will = probably > > immediately shut the machine down due to overtemperature if started= below > > 0=B0C. > > > > 'long' is 64bit on several architectures. This is not needed since = INT_MAX =B0mC > > is above the melting point of all known materials. > > > > Consistently use a plain 'int' for temperatures throughout the ther= mal code and > > the drivers. This only changes the places in the drivers where the = temperature > > is passed around as pointer, when drivers internally use another ty= pe this is > > not changed. > > > > Signed-off-by: Sascha Hauer >=20 > Thanks for moving over the thermal sub-system in Linux to consistentl= y > use a single type. >=20 > In your patch, you missed migrating over power_allocator governor and > it's associated trace events. It got merged for v4.2. >=20 > Could you incorporate something like below in your next version? It seems I have changed drivers/thermal/power_allocator.c but missed include/trace/events/thermal_power_allocator.h. Please check out the v2 patch I just sent. Sascha --=20 Pengutronix e.K. | = | Industrial Linux Solutions | http://www.pengutronix.de/= | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 = | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-555= 5 |