From: Sebastian Reichel <sre@kernel.org>
To: Frans Klaver <fransklaver@gmail.com>
Cc: Vaishali Thakkar <vthakkar1994@gmail.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] power_supply: Adjust devm usage
Date: Fri, 24 Jul 2015 15:01:59 +0200 [thread overview]
Message-ID: <20150724130158.GB25447@earth> (raw)
In-Reply-To: <CAH6sp9ODe9EQjYgkjUr8P-bhhtgshqJovEcOVwKSP_FiuTo8Fw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 691 bytes --]
Hi,
On Fri, Jul 24, 2015 at 02:39:12PM +0200, Frans Klaver wrote:
> On Fri, Jul 24, 2015 at 2:26 PM, Sebastian Reichel <sre@kernel.org> wrote:
> > On Fri, Jul 24, 2015 at 05:28:13PM +0530, Vaishali Thakkar wrote:
> >> Use devm_kasprintf instead of kasprintf. Also, remove various
> >> gotos by direct returns and drop unneeded label err_free_name.
> >
> > Please also use devm_power_supply_unregister() instead
> > of power_supply_unregister() to further simplify the driver.
>
> Sounds like a separate patch.
I would be fine with either one or two patches. It's common, that
devm conversion happens in one commit instead of one patch per
function change.
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-07-24 13:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 11:58 [PATCH] power_supply: Adjust devm usage Vaishali Thakkar
2015-07-24 12:17 ` Frans Klaver
2015-07-24 12:29 ` Krzysztof Kozlowski
2015-07-24 12:35 ` Vaishali Thakkar
2015-07-24 12:26 ` Sebastian Reichel
2015-07-24 12:33 ` Vaishali Thakkar
2015-07-24 12:59 ` Sebastian Reichel
2015-07-24 13:14 ` Vaishali Thakkar
2015-07-24 13:38 ` Sebastian Reichel
2015-07-24 13:42 ` Vaishali Thakkar
2015-07-24 12:36 ` Krzysztof Kozlowski
2015-07-24 12:39 ` Frans Klaver
2015-07-24 13:01 ` Sebastian Reichel [this message]
2015-08-02 6:53 ` Pavel Machek
2015-08-03 17:29 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150724130158.GB25447@earth \
--to=sre@kernel.org \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=fransklaver@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=vthakkar1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).