Re: [PATCH 1/4] opp: add dev_pm_opp_is_turbo() helper

[Pavel Machek <pavel@ucw.cz>]

On Tue 2015-07-28 16:50:00, Viresh Kumar wrote:
> From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> 
> Add dev_pm_opp_is_turbo() helper to verify if an opp is to be used only
> for turbo mode or not.
> 
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Javier Martinez Canillas <javier@dowhile0.org>
> Cc: Thomas Abraham <thomas.ab@samsung.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  drivers/base/power/opp.c | 30 ++++++++++++++++++++++++++++++
>  include/linux/pm_opp.h   |  7 +++++++
>  2 files changed, 37 insertions(+)
> 
> diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
> index b38f2600d797..a0c54058c4dd 100644
> --- a/drivers/base/power/opp.c
> +++ b/drivers/base/power/opp.c
> @@ -281,6 +281,36 @@ unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp)
>  EXPORT_SYMBOL_GPL(dev_pm_opp_get_freq);
>  
>  /**
> + * dev_pm_opp_is_turbo() - Returns true if opp was trubo OPP

Typo.

And this is not exactly most helpful comment. opp is turbo... returns
if opp was turbo. Explanation what "turbo" means in this context would
be nice. I'm pretty sure it is not about air compression :-).

> + * Return: true if opp is turbo opp, else false.

Duplicate from above.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html