From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH V3 06/16] PM / OPP: Break _opp_add_dynamic() into smaller functions Date: Thu, 30 Jul 2015 22:43:56 -0700 Message-ID: <20150731054356.GI3159@codeaurora.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:35178 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957AbbGaFn6 (ORCPT ); Fri, 31 Jul 2015 01:43:58 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Viresh Kumar Cc: Rafael Wysocki , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, rob.herring@linaro.org, arnd.bergmann@linaro.org, nm@ti.com, broonie@kernel.org, mturquette@baylibre.com, Sudeep.Holla@arm.com, viswanath.puttagunta@linaro.org, l.stach@pengutronix.de, thomas.petazzoni@free-electrons.com, linux-arm-kernel@lists.infradead.org, ta.omasab@gmail.com, kesavan.abhilash@gmail.com, khilman@linaro.org, santosh.shilimkar@oracle.com, b.zolnierkie@samsung.com, Greg Kroah-Hartman , Len Brown , open list , Pavel Machek On 07/29, Viresh Kumar wrote: > Later commits would add support for new OPP bindings and this would be > required then. So, lets do it in a separate patch to make it easily > reviewable. > > Another change worth noticing is INIT_LIST_HEAD(&opp->node). We weren't > doing it earlier as we never tried to delete a list node before it is > added to list. But this wouldn't be the case anymore. We might try to > delete a node (just to reuse the same code paths), without it being > getting added to the list. > > Reviewed-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Viresh Kumar > --- Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project