From: Viresh Kumar <viresh.kumar@linaro.org>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
박경민 <kyungmin.park@samsung.com>,
"open list:DEVICE FREQUENCY (DEVFREQ)" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 03/15] drivers: devfreq: Drop unlikely before IS_ERR(_OR_NULL)
Date: Mon, 3 Aug 2015 11:17:58 +0530 [thread overview]
Message-ID: <20150803054758.GA16589@linux> (raw)
In-Reply-To: <1641980442.342501438578642999.JavaMail.weblogic@epmlwas06d>
On 03-08-15, 05:10, MyungJoo Ham wrote:
> > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
> > is no need to do that again from its callers. Drop it.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> @ from include/linux/err.h
> #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
> ...
> static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr)
> {
> return !ptr || IS_ERR_VALUE((unsigned long)ptr);
> }
>
> "!ptr" appears not covered with IS_ERR_OR_NULL.
> (only the IS_ERR part seems covered)
Right, the first patch of the series has fixed that.
http://permalink.gmane.org/gmane.linux.kernel/2009151
--
viresh
next prev parent reply other threads:[~2015-08-03 5:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 5:10 [PATCH 03/15] drivers: devfreq: Drop unlikely before IS_ERR(_OR_NULL) MyungJoo Ham
2015-08-03 5:47 ` Viresh Kumar [this message]
[not found] <cover.1438331416.git.viresh.kumar@linaro.org>
2015-07-31 8:38 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150803054758.GA16589@linux \
--to=viresh.kumar@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=kyungmin.park@samsung.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).