* Re: Re: [PATCH 03/15] drivers: devfreq: Drop unlikely before IS_ERR(_OR_NULL)
@ 2015-08-03 5:50 MyungJoo Ham
2015-08-03 5:55 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: MyungJoo Ham @ 2015-08-03 5:50 UTC (permalink / raw)
To: Viresh Kumar
Cc: akpm@linux-foundation.org, linaro-kernel@lists.linaro.org,
linux-kernel@vger.kernel.org, 박경민,
open list:DEVICE FREQUENCY (DEVFREQ)
> On 03-08-15, 05:10, MyungJoo Ham wrote:
> > > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
> > > is no need to do that again from its callers. Drop it.
> > >
> > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
> > @ from include/linux/err.h
> > #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
> > ...
> > static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr)
> > {
> > return !ptr || IS_ERR_VALUE((unsigned long)ptr);
> > }
> >
> > "!ptr" appears not covered with IS_ERR_OR_NULL.
> > (only the IS_ERR part seems covered)
>
> Right, the first patch of the series has fixed that.
>
> http://permalink.gmane.org/gmane.linux.kernel/2009151
Ah.. ok, then,
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
please let me know when the series is ready to go.
Cheers,
MyungJoo
>
> --
> viresh
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-03 5:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-03 5:50 Re: [PATCH 03/15] drivers: devfreq: Drop unlikely before IS_ERR(_OR_NULL) MyungJoo Ham
2015-08-03 5:55 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).