linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
	nm@ti.com, linaro-kernel@lists.linaro.org,
	linux-pm@vger.kernel.org, khilman@linaro.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Len Brown <len.brown@intel.com>,
	open list <linux-kernel@vger.kernel.org>,
	Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH 1/6] PM / OPP: reuse of_parse_phandle()
Date: Tue, 11 Aug 2015 11:40:44 +0530	[thread overview]
Message-ID: <20150811061044.GA5147@linux> (raw)
In-Reply-To: <20150811060229.GG9678@codeaurora.org>

On 10-08-15, 23:02, Stephen Boyd wrote:
> > -	if (prop->length != sizeof(__be32)) {
> > -		dev_err(dev, "%s: Invalid opp desc phandle\n", __func__);
> > -		return ERR_PTR(-EINVAL);
> > -	}
> 
> But we lost this check? Perhaps we can use
> of_count_phandle_with_args() to make suer we only have one
> phandle?

I thought about it earlier and it looked like we don't need to care
about this. Even if the user passes multiple strings here, its his
problem. We will just pick the first entry and parse it.

And that's true until the point we support multiple table entries,
ofcourse :)

Now that you are still awake, let me update the other patches as well
where u commented :)

-- 
viresh

  reply	other threads:[~2015-08-11  6:10 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10  6:31 [PATCH 0/6] PM / OPP: Add debugfs support Viresh Kumar
2015-08-10  6:31 ` [PATCH 1/6] PM / OPP: reuse of_parse_phandle() Viresh Kumar
2015-08-11  6:02   ` Stephen Boyd
2015-08-11  6:10     ` Viresh Kumar [this message]
2015-08-11  6:23       ` Stephen Boyd
2015-08-11  6:42         ` Viresh Kumar
2015-08-10  6:31 ` [PATCH 2/6] PM / OPP: restructure _of_init_opp_table_v2() Viresh Kumar
2015-08-10 19:23   ` Stephen Boyd
2015-08-11  0:23     ` Viresh Kumar
2015-08-11  0:31       ` Stephen Boyd
2015-08-11  2:25         ` Viresh Kumar
2015-08-11  6:08           ` Stephen Boyd
2015-08-11  6:57             ` Viresh Kumar
2015-08-11  8:37               ` Viresh Kumar
2015-08-11  2:33         ` Viresh Kumar
2015-08-11  6:09           ` Stephen Boyd
2015-08-10  6:31 ` [PATCH 3/6] PM / OPP: Prefix exported opp routines with dev_pm_opp_ Viresh Kumar
2015-08-10 19:24   ` Stephen Boyd
2015-08-10  6:32 ` [PATCH 4/6] PM / OPP: Move opp core to its own directory Viresh Kumar
2015-08-10 19:51   ` Stephen Boyd
2015-08-11  0:25     ` Viresh Kumar
2015-08-10  6:32 ` [PATCH 5/6] PM / OPP: Move cpu specific code to opp/cpu.c Viresh Kumar
2015-08-11  6:09   ` Stephen Boyd
2015-08-10  6:32 ` [PATCH 6/6] PM / OPP: Add debugfs support Viresh Kumar
2015-08-10 19:50   ` Stephen Boyd
2015-08-11  6:35     ` Viresh Kumar
2015-08-11  6:37     ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150811061044.GA5147@linux \
    --to=viresh.kumar@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=khilman@linaro.org \
    --cc=len.brown@intel.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).