From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 1/6] PM / OPP: reuse of_parse_phandle() Date: Mon, 10 Aug 2015 23:23:53 -0700 Message-ID: <20150811062353.GA31523@codeaurora.org> References: <8c4503fe1c1c545d5f7ac68351d81d0238532b54.1439187821.git.viresh.kumar@linaro.org> <20150811060229.GG9678@codeaurora.org> <20150811061044.GA5147@linux> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150811061044.GA5147@linux> Sender: linux-kernel-owner@vger.kernel.org To: Viresh Kumar Cc: Rafael Wysocki , nm@ti.com, linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, khilman@linaro.org, Greg Kroah-Hartman , Len Brown , open list , Pavel Machek List-Id: linux-pm@vger.kernel.org On 08/11, Viresh Kumar wrote: > On 10-08-15, 23:02, Stephen Boyd wrote: > > > - if (prop->length != sizeof(__be32)) { > > > - dev_err(dev, "%s: Invalid opp desc phandle\n", __func__); > > > - return ERR_PTR(-EINVAL); > > > - } > > > > But we lost this check? Perhaps we can use > > of_count_phandle_with_args() to make suer we only have one > > phandle? > > I thought about it earlier and it looked like we don't need to care > about this. Even if the user passes multiple strings here, its his > problem. We will just pick the first entry and parse it. > > And that's true until the point we support multiple table entries, > ofcourse :) Ok. That's worth a mention in the commit text please. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project