From: Viresh Kumar <viresh.kumar@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
nm@ti.com, linaro-kernel@lists.linaro.org,
linux-pm@vger.kernel.org, khilman@linaro.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Len Brown <len.brown@intel.com>,
open list <linux-kernel@vger.kernel.org>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH 2/6] PM / OPP: restructure _of_init_opp_table_v2()
Date: Tue, 11 Aug 2015 14:07:44 +0530 [thread overview]
Message-ID: <20150811083744.GF5509@linux> (raw)
In-Reply-To: <20150811065738.GE5147@linux>
On 11-08-15, 12:27, Viresh Kumar wrote:
> diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
> index 1daaa1a418a2..be3356a3a452 100644
> --- a/drivers/base/power/opp.c
> +++ b/drivers/base/power/opp.c
> @@ -1292,14 +1292,18 @@ static int _of_init_opp_table_v2(struct device *dev,
> }
>
> /* There should be one of more OPP defined */
> - if (WARN_ON(!count))
> + if (WARN_ON(!count)) {
> + ret = -ENOENT;
> goto out;
> + }
>
> if (!ret) {
> if (!dev_opp) {
> dev_opp = _find_device_opp(dev);
> - if (WARN_ON(!dev_opp))
> + if (WARN_ON(!dev_opp)) {
Dan also reported that !dev_opp isn't enough as we need to use IS_ERR
here.
We have got enough updates here, let me resend the series again to get
more reviews on proper patches.
--
viresh
next prev parent reply other threads:[~2015-08-11 8:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 6:31 [PATCH 0/6] PM / OPP: Add debugfs support Viresh Kumar
2015-08-10 6:31 ` [PATCH 1/6] PM / OPP: reuse of_parse_phandle() Viresh Kumar
2015-08-11 6:02 ` Stephen Boyd
2015-08-11 6:10 ` Viresh Kumar
2015-08-11 6:23 ` Stephen Boyd
2015-08-11 6:42 ` Viresh Kumar
2015-08-10 6:31 ` [PATCH 2/6] PM / OPP: restructure _of_init_opp_table_v2() Viresh Kumar
2015-08-10 19:23 ` Stephen Boyd
2015-08-11 0:23 ` Viresh Kumar
2015-08-11 0:31 ` Stephen Boyd
2015-08-11 2:25 ` Viresh Kumar
2015-08-11 6:08 ` Stephen Boyd
2015-08-11 6:57 ` Viresh Kumar
2015-08-11 8:37 ` Viresh Kumar [this message]
2015-08-11 2:33 ` Viresh Kumar
2015-08-11 6:09 ` Stephen Boyd
2015-08-10 6:31 ` [PATCH 3/6] PM / OPP: Prefix exported opp routines with dev_pm_opp_ Viresh Kumar
2015-08-10 19:24 ` Stephen Boyd
2015-08-10 6:32 ` [PATCH 4/6] PM / OPP: Move opp core to its own directory Viresh Kumar
2015-08-10 19:51 ` Stephen Boyd
2015-08-11 0:25 ` Viresh Kumar
2015-08-10 6:32 ` [PATCH 5/6] PM / OPP: Move cpu specific code to opp/cpu.c Viresh Kumar
2015-08-11 6:09 ` Stephen Boyd
2015-08-10 6:32 ` [PATCH 6/6] PM / OPP: Add debugfs support Viresh Kumar
2015-08-10 19:50 ` Stephen Boyd
2015-08-11 6:35 ` Viresh Kumar
2015-08-11 6:37 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150811083744.GF5509@linux \
--to=viresh.kumar@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@linaro.org \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).