From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH v2 07/16] efi: Make efi_status_to_err() public Date: Thu, 20 Aug 2015 16:07:06 +0100 Message-ID: <20150820150706.GE2567@codeblueprint.co.uk> References: <1439273796-25359-1-git-send-email-jlee@suse.com> <1439273796-25359-8-git-send-email-jlee@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-wi0-f169.google.com ([209.85.212.169]:38264 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752494AbbHTPHK (ORCPT ); Thu, 20 Aug 2015 11:07:10 -0400 Received: by wicja10 with SMTP id ja10so38820552wic.1 for ; Thu, 20 Aug 2015 08:07:09 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1439273796-25359-8-git-send-email-jlee@suse.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "Lee, Chun-Yi" Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Matthew Garrett , Len Brown , Pavel Machek , Josh Boyer , Vojtech Pavlik , Matt Fleming , Jiri Kosina , "H. Peter Anvin" , Ingo Molnar , "Lee, Chun-Yi" On Tue, 11 Aug, at 02:16:27PM, Lee, Chun-Yi wrote: > Moved the function of transferring EFI status to kernel error for > later used by EFI stub. Might I suggest: "Move the function for converting EFI status to kernel error values from drivers/firmware/efi/ to include/linux/efi.h for use by the x86 EFI stub in an upcoming patch." ? > Reviewed-by: Jiri Kosina > Tested-by: Jiri Kosina > Signed-off-by: Lee, Chun-Yi > --- > drivers/firmware/efi/vars.c | 33 --------------------------------- > include/linux/efi.h | 33 +++++++++++++++++++++++++++++++++ > 2 files changed, 33 insertions(+), 33 deletions(-) The patch content is fine, Reviewed-by: Matt Fleming -- Matt Fleming, Intel Open Source Technology Center