From: Javi Merino <javi.merino@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Vaishali Thakkar <vthakkar1994@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] thermal: cpu_cooling: Remove usage of devm functions
Date: Wed, 26 Aug 2015 14:09:21 +0100 [thread overview]
Message-ID: <20150826130921.GB10956@e104805> (raw)
In-Reply-To: <20150826125158.GM8784@linux>
On Wed, Aug 26, 2015 at 01:51:58PM +0100, Viresh Kumar wrote:
> On 26-08-15, 13:47, Javi Merino wrote:
> > I missed this because I wasn't CCed :( Thankfully, I'll be in
> > MAINTAINERS for this soon.
>
> Yeah, I need to resend that patch soon :)
>
> > > - devm_kfree(&cdev->device, load_cpu);
> >
> > This introduces a memory leak. Keep the kfree() here, you can't drop
> > it. Cheers,
> > Javi
> >
> > > - }
> > > -
> > > *power = static_power + dynamic_power;
> > > return 0;
> > > +
> > > +free:
> > > + kfree(load_cpu);
>
> Wouldn't this make that work ?
Nope, you're not reaching that code path from there. Removing the
"return 0" would work, but I don't like it, since we would be calling
kfree() all the time, even when the trace is not enabled. I'd rather
leave the kfree() where it is.
Cheers,
Javi
next prev parent reply other threads:[~2015-08-26 13:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 16:14 [PATCH v2] thermal: cpu_cooling: Remove usage of devm functions Vaishali Thakkar
2015-08-20 16:17 ` Viresh Kumar
2015-08-26 12:47 ` Javi Merino
2015-08-26 12:51 ` Viresh Kumar
2015-08-26 13:09 ` Javi Merino [this message]
2015-08-26 13:14 ` Viresh Kumar
2015-08-27 1:31 ` Vaishali Thakkar
2015-08-27 9:00 ` Javi Merino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826130921.GB10956@e104805 \
--to=javi.merino@arm.com \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=viresh.kumar@linaro.org \
--cc=vthakkar1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox