Re: [PATCH v2] thermal: cpu_cooling: Remove usage of devm functions

Javi Merino
2015-08-27T09:00:23Z

On Thu, Aug 27, 2015 at 02:31:26AM +0100, Vaishali Thakkar wrote:
> On Wed, Aug 26, 2015 at 6:44 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > On 26-08-15, 14:09, Javi Merino wrote:
> >> On Wed, Aug 26, 2015 at 01:51:58PM +0100, Viresh Kumar wrote:
> >> > On 26-08-15, 13:47, Javi Merino wrote:
> >> > > I missed this because I wasn't CCed :( Thankfully, I'll be in
> >> > > MAINTAINERS for this soon.
> >> >
> >> > Yeah, I need to resend that patch soon :)
> >> >
> >> > > > - devm_kfree(&cdev->device, load_cpu);
> >> > >
> >> > > This introduces a memory leak. Keep the kfree() here, you can't drop
> >> > > it. Cheers,
> >> > > Javi
> >> > >
> >> > > > - }
> >> > > > -
> >> > > > *power = static_power + dynamic_power;
> >> > > > return 0;
> >
> > So, the change I suggested on V1 removed this as well :) and Vaishali
> > missed it completely.
>
> Yes. I missed the point that kfree was called at 2 places previously.
> Would you like me to send v3 with changes having just new label with
> 'goto' at both of these places or you would like to apply v1 of the patch?

I vote for v1. I've acked it.

Cheers,
Javi