From: Jisheng Zhang <jszhang@marvell.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: vichy <vichy.kuo@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>
Subject: Re: about system time incorrect after changing cpu frequency
Date: Tue, 1 Sep 2015 14:39:23 +0800 [thread overview]
Message-ID: <20150901143923.11b075b5@xhacker> (raw)
In-Reply-To: <20150901060236.GB1456@linux>
On Tue, 1 Sep 2015 11:32:36 +0530
Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 01-09-15, 13:36, vichy wrote:
> > >> I try to call below 2 functions to change the frequency of clocksource
> > >> and clockevent, but the above b) sleep time is still incorrect when
> > >> cpu runs in 500Mhz.
> > >> clockevents_update_freq(this_cpu_ptr(gt_evt), gt_clk_rate);
> > >> __clocksource_updatefreq_hz(>_clocksource, gt_clk_rate);
>
> How and when were you calling them? What kernel version is it ?
>
> > Clock Event Device: arm_global_timer
>
> This driver doesn't have support to update clkevt device's freq. You
> may need to modify that based on how arch/arm/kernel/smp_twd.c is
> updated. look for: clockevents_update_freq().
>
This can only help the clockevent. Even with this cpufreq notifier
update, the globaltimer clocksource still can't hold correct/accurate time.
I think the arm global timer is not suitable for clocksource if cpufreq is
enabled.
next prev parent reply other threads:[~2015-09-01 6:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAOVJa8GTDj3UJpgUd4nH1wknUKa6fgac=1SsqC8g=UCG0MGuDw@mail.gmail.com>
2015-09-01 3:57 ` about system time incorrect after changing cpu frequency Viresh Kumar
2015-09-01 5:36 ` vichy
2015-09-01 6:02 ` Viresh Kumar
2015-09-01 6:39 ` Jisheng Zhang [this message]
2015-09-01 7:37 ` vichy
2015-09-01 7:21 ` vichy
2015-09-01 7:42 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901143923.11b075b5@xhacker \
--to=jszhang@marvell.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=vichy.kuo@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).