From: Pavel Machek <pavel@ucw.cz>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
sboyd@codeaurora.org, linaro-kernel@lists.linaro.org,
linux-pm@vger.kernel.org, nm@ti.com, khilman@linaro.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Len Brown <len.brown@intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines with dev_pm_opp_
Date: Tue, 1 Sep 2015 21:03:21 +0200 [thread overview]
Message-ID: <20150901190321.GA6123@amd> (raw)
In-Reply-To: <7c5fd48b6e94fb84f44eb1e79d4518cbf3de6909.1441083292.git.viresh.kumar@linaro.org>
Hi!
> -EXPORT_SYMBOL_GPL(of_cpumask_init_opp_table);
> +EXPORT_SYMBOL_GPL(dev_pm_opp_cpumask_init_opp);
Well... it starts to be rather long and repetitive.
> @@ -237,7 +237,7 @@ static int cpufreq_init(struct cpufreq_policy *policy)
> *
> * OPPs might be populated at runtime, don't check for error here
> */
> - of_cpumask_init_opp_table(policy->cpus);
> + dev_pm_opp_cpumask_init_opp(policy->cpus);
>
> if (need_update) {
> struct cpufreq_dt_platform_data *pd = cpufreq_get_driver_data();
...
> @@ -356,7 +356,7 @@ static int cpufreq_init(struct cpufreq_policy *policy)
> out_free_priv:
> kfree(priv);
> out_free_opp:
> - of_cpumask_free_opp_table(policy->cpus);
> + dev_pm_opp_cpumask_free_table(policy->cpus);
> out_node_put:
> of_node_put(np);
> out_put_reg_clk:
Is ..._free_table opposite of ..._init_opp? If so, you might want to
name them such that it is clear...
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-09-01 19:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 4:58 [PATCH V2 Resend 0/5] PM / OPP: Add debugfs support Viresh Kumar
2015-09-01 4:58 ` [PATCH V2 Resend 1/5] PM / OPP: reuse of_parse_phandle() Viresh Kumar
2015-09-01 22:48 ` Stephen Boyd
2015-09-01 4:58 ` [PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines with dev_pm_opp_ Viresh Kumar
2015-09-01 19:03 ` Pavel Machek [this message]
2015-09-02 7:22 ` Viresh Kumar
2015-09-02 7:25 ` Viresh Kumar
2015-09-03 0:00 ` Stephen Boyd
2015-09-01 4:58 ` [PATCH V2 Resend 3/5] PM / OPP: Move opp core to its own directory Viresh Kumar
2015-09-01 22:51 ` Stephen Boyd
2015-09-02 7:13 ` Viresh Kumar
2015-09-01 4:58 ` [PATCH V2 Resend 4/5] PM / OPP: Move cpu specific code to opp/cpu.c Viresh Kumar
2015-09-01 4:58 ` [PATCH V2 Resend 5/5] PM / OPP: Add debugfs support Viresh Kumar
2015-09-01 23:00 ` Stephen Boyd
2015-09-03 1:05 ` [PATCH V2 Resend 0/5] " Rafael J. Wysocki
2015-09-03 4:32 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901190321.GA6123@amd \
--to=pavel@ucw.cz \
--cc=b.zolnierkie@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@linaro.org \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).