From: Viresh Kumar <viresh.kumar@linaro.org>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] cpufreq: dt: Tolerance applies on both sides of target voltage
Date: Wed, 2 Sep 2015 15:14:56 +0530 [thread overview]
Message-ID: <20150902094456.GC26744@linux> (raw)
In-Reply-To: <1441186785.3137.2.camel@pengutronix.de>
On 02-09-15, 11:39, Lucas Stach wrote:
> Am Mittwoch, den 02.09.2015, 14:36 +0530 schrieb Viresh Kumar:
> > Tolerance applies on both sides of the target voltage, i.e. both min and
> > max sides.
>
> While I'm not really comfortable with the above, it is exactly how OPPv1
> and the voltage tolerance property are specified.
>
> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Thanks.
And this is exactly how the regulator API work:
static inline int regulator_set_voltage_tol(struct regulator *regulator,
int new_uV, int tol_uV)
{
if (regulator_set_voltage(regulator, new_uV, new_uV + tol_uV) == 0)
return 0;
else
return regulator_set_voltage(regulator,
new_uV - tol_uV, new_uV + tol_uV);
}
But yeah, OPP-v2 is going to take care of this with target/min/max
values..
--
viresh
next prev parent reply other threads:[~2015-09-02 9:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 9:06 [PATCH 0/3] cpufreq: dt: Minor fixes for 4.3 Viresh Kumar
2015-09-02 9:06 ` [PATCH 1/3] cpufreq: dt: Check OPP count before marking them shared Viresh Kumar
2015-09-02 9:06 ` [PATCH 2/3] cpufreq: dt: Print error on failing to mark OPPs as shared Viresh Kumar
2015-09-02 9:06 ` [PATCH 3/3] cpufreq: dt: Tolerance applies on both sides of target voltage Viresh Kumar
2015-09-02 9:39 ` Lucas Stach
2015-09-02 9:44 ` Viresh Kumar [this message]
2015-09-03 1:14 ` [PATCH 0/3] cpufreq: dt: Minor fixes for 4.3 Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902094456.GC26744@linux \
--to=viresh.kumar@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).