From: Viresh Kumar <viresh.kumar@linaro.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] cpufreq: Add ARM_MT8173_CPUFREQ dependencyon THERMAL
Date: Thu, 3 Sep 2015 21:20:29 +0530 [thread overview]
Message-ID: <20150903155029.GB5332@linux> (raw)
In-Reply-To: <1441293658-18199-1-git-send-email-linux@roeck-us.net>
On 03-09-15, 08:20, Guenter Roeck wrote:
> If ARM_MT8173_CPUFREQ is configured, and THERMAL is configured as module,
> the following build error is seen for arm:allmodconfig and
> arm64:allmodconfig.
>
> drivers/built-in.o: In function `mtk_cpufreq_ready':
> :(.text+0x32a20c): undefined reference to `of_cpufreq_cooling_register'
> drivers/built-in.o: In function `mtk_cpufreq_exit':
> :(.text+0x32a420): undefined reference to `cpufreq_cooling_unregister'
>
> The fix is similar to CPUFREQ_DT, but more restrictive since
> ARM_MT8173_CPUFREQ can not be built as module.
>
> Fixes: 1453863fb02a ("cpufreq: mediatek: Add MT8173 cpufreq driver")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> It might also make sense to declare ARM_MT8173_CPUFREQ as tristate
> and relax the conditions, but I don't know if that is feasible.
>
> drivers/cpufreq/Kconfig.arm | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2015-09-03 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 15:20 [PATCH] cpufreq: Add ARM_MT8173_CPUFREQ dependencyon THERMAL Guenter Roeck
2015-09-03 15:50 ` Viresh Kumar [this message]
2015-09-04 19:01 ` Olof Johansson
2015-09-04 19:40 ` Guenter Roeck
2015-09-04 22:27 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150903155029.GB5332@linux \
--to=viresh.kumar@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).